JavaFX：双向绑定不更新 TextField

Question

I'm playing around with JavaFX and try to create a GUI which saves its state right after a change.

Class UiState encapsulates all properties:

public class UiState {

  private static final Preferences PREFS = Preferences.userNodeForPackage(UiState.class);
  public static final StringProperty FOLDER_PROP_STATISTICS = new BindingProperty("FOLDER_PROP_STATISTICS",
        "C:\\Temp\\");

    //This is a Stringproperty, which accesses the Preferences 
    protected static class BindingProperty extends SimpleStringProperty {
        private final String def;
        private final String bindingName;

        public BindingProperty(final String bindingName) {
            this(bindingName, "");
        }

        public BindingProperty(final String bindingName, final String def) {
            this.def = def;
            this.bindingName = bindingName;
        }

        @Override
        public String get() {
            return PREFS.get(bindingName, def);
        }

        @Override
        public void set(final String newValue) {
            PREFS.put(bindingName, newValue);

        }

    }

The GUI is created like this:

protected void configFileComponents() {

    final TextField folderTextField = getPropertyTextFieldWithLabel("Target folder", UiState.FOLDER_PROP_STATISTICS );

    folderTextField.setOnMouseClicked(target -> {
        onFileChooseButtonClicked();

    });
}

private void onFileChooseButtonClicked() {
    final DirectoryChooser chooser = new DirectoryChooser();
    chooser.setTitle("Select target folder");
    final String folder = getFolderProperty().get();
    if (!(folder == null || folder.isEmpty())) {
        chooser.setInitialDirectory(new File(folder));
    }

    final File result = chooser.showDialog(getScene().getWindow());
    if (result != null) {
        getFolderProperty().set(result.getAbsolutePath());
    }
}

protected TextField getPropertyTextFieldWithLabel(final String label, final StringProperty property) {
    final Label fileLabel = new Label(label);
    addLeft(fileLabel);
    final TextField result = new TextField();
    result.setText(property.get());
    addRight(result);
    //I thought this would be enough
    result.textProperty().bindBidirectional(property);
    return result;
}

Once a folder is selected via DirectoryChooser , the StringProperty FOLDER_PROP_STATISTICS is updated. But the TextField does not display the new value. Did I miss something, or did I make a fundamental mistake?

Answer 1

VGR was right, it was naiv to override get() and set() BindingProperty . My new Class looks like this and works like a charm:

protected static class BindingProperty extends SimpleStringProperty {

    public BindingProperty(final String bindingName, final String def) {
        super(PREFS.get(bindingName, def));
        this.addListener(
                (ChangeListener<String>) (observable, oldValue, newValue) -> PREFS.put(bindingName, newValue));
    }

    public BindingProperty(final String bindingName) {
        this(bindingName, "");
    }

}