简体   繁体   English

jQuery:避免过多的递归

[英]jquery: avoid too much recursion

I have a script that distribute the 54 playing cards randomly on 4 players, it will generate 2 random numbers to get a random card, the category number (from 1 to 4) which means: "hearts,spades,diamonds,clubs", and the card number (from 1 to 13). 我有一个脚本,将54张纸牌随机分配给4个玩家,它将生成2个随机数字以获得一张随机纸牌,类别编号(从1到4),其含义是:“红心,黑桃,钻石,俱乐部”,以及卡号(从1到13)。

The problem is there are too much recursions in this script, so how I can avoid this error by calling the functions in threads or something similar? 问题是此脚本中的递归过多,因此如何通过在线程或类似对象中调用函数来避免此错误?

my code: 我的代码:

$(document).ready(function(){
    var human = [];
    var east = [];
    var west = [];
    var north = [];
    var used_cards = [];

    distributeCards(north,$('#north'));
    distributeCards(east,$('#east'),'vertical');
    distributeCards(west,$('#west'));
    distributeCards(human,$('#south'));

    function distributeCards(array,container,view){
        for(var i = 0; i < 13; i++){
            var category,card;
            do{
                var uniqueCard = uniqueRandomCard();
            }while(typeof uniqueCard === "undefined")
            category = uniqueCard[0];
            card = uniqueCard[1];
            array.push(uniqueCard);
            var category_name = '';
            if(category === 1){
                category_name = 'hearts';
            }
            else if(category === 2){
                category_name = 'spades';
            }
            else if(category === 3){
                category_name = 'diamonds';
            }
            else if(category === 4){
                category_name = 'clubs';
            }
            if(card === 1){
                card = 'ace';
            }
            else if(card === 11){
                card = 'jack';
            }
            else if(card === 12){
                card = 'queen';
            }
            else if(card === 13){
                card = 'king';
            }
            if(view === 'vertical'){
                $(container).children('.row').append('<img src="cards/backRotate.png" class="card"/>');
            }
            else if(view === 'horizontal'){
                $(container).children('.row').append('<img src="cards/back.png" class="card"/>');
            }
        }
    }
    function randomNumberFromRange(min,max){
        return Math.round(Math.floor(Math.random()*max)+min);
    }
    function uniqueRandomCard(){
        var card = randomNumberFromRange(1, 13);
        var category = randomNumberFromRange(1, 4);
        if(!inAssocArray(category,card,used_cards)){
            var array = [];
            array[0] = category;
            array[1] = card;
            used_cards.push(array);
            return array;
        }
        else{
            uniqueRandomCard();
        }
    }
    function inAssocArray(key,value,array){
        var flag = false;
        for(var i = 0; i < array.length; i++){
            if(array[i][0] === key && array[i][1]=== value){
                flag = true;
            }
        }
        return flag;
    }
});

Fixing recursion the way you've implemented it is quite easy. 按照实现的方式修复递归非常容易。 Simply replace your call and if statement with a while statement. 只需用while语句替换您的调用和if语句。

function uniqueRandomCard(){
  var card = randomNumberFromRange(1, 13);
  var category = randomNumberFromRange(1, 4);
  while(inAssocArray(category,card,used_cards)) {
    card = randomNumberFromRange(1, 13);
    category = randomNumberFromRange(1, 4);
  }
  var array = [];
  array[0] = category;
  array[1] = card;
  used_cards.push(array);
  return array;
}

That being said there are some fundamental better ways of handling limited sets like this. 话虽这么说,但是有一些根本的更好的方法来处理像这样的有限集合。 Storing unused cards and randomly selecting from that is far superior. 存储未使用的卡并从中随机选择要好得多。

声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.

 
粤ICP备18138465号  © 2020-2024 STACKOOM.COM