php登录不起作用

Question

I'm working on a login system and I want, In case the user entered wrong username & password to return him to the login page and if its ok redirect to admin/index.php it's not working and no errors .

Function code And the html code

    if(isset($_POST['submit_form'])){
        $username = mysqli_real_escape_string($_POST['username']);
        $password = mysqli_real_escape_string($_POST['password']);
        $query = mysqli_query("SELECT * FROM users WHERE username = '$username' AND   password ='{$password'");
        if($query==false){
            set_message(" Your password or username are wrong ");
            redirect("login.php");
        }else{
            redirect("admin");
        }
    }

The Html code

<form class="form-inline" role="form" action="" method="post" enctype="multipart/form-data">
    <div class="form-group">        
        <label class="form-group" for="username">username</label>
        <input type="text" name="username" class="form-control" id="username" placeholder="username">
    </div>
    <div class="form-group">
        <label class="sr-only" for="password">Password</label>
        <input type="password" name="password" class="form-control" id="password" placeholder="password">
    </div>
    <button type="submit" name="submit_form" class="btn btn-black">
    <input type="hidden" name="submit_form" value="<?php echo session_id()"/>
        Login
    </button>
</form>

The functions

function redirect($location) {
    header("Location : $location"); 
}

function query($sql){
    global $connection ;
    return mysqli_query($connection, $sql);
}

function confirm($result){
    global $connection;
    if(!$result){
        die("QUERY FAILED " . mysqli_error($connection));
    } 
}

function escape_string($string){
    global $connection ;
    return mysqli_real_escape_string($connection, $string);
} 

Answer 1

Yes, sorry i am just getting used to this thing. Thanks for pointing out the mistake.

    //this will eliminate the BOT hitting up the forms
    if(isset($_POST['submit_form']) && $_POST['submit_form']==session_id()){
    $username = mysql_real_escape_string($_POST['username']);
    $password = mysql_real_escape_string($_POST['password']);
    $query = mysqli_query("SELECT * FROM users WHERE username = '$username' AND   password ='$password'");
    if($query==false){
        set_message(" Your password or username are wrong ");
        redirect("login.php");
    }else{
        redirect("admin");
    }
}

And I updated the form as well.

  <form class="form-inline" role="form" action="" method="post" enctype="multipart/form-data">
<div class="form-group">        
    <label class="form-group" for="username">username</label>
    <input type="text" name="username" class="form-control" id="username" placeholder="username">
</div>
<div class="form-group">
    <label class="sr-only" for="password">Password</label>
    <input type="password" name="password" class="form-control" id="password" placeholder="password">
</div>
<button type="submit" name="submit_form" class="btn btn-black">

    Login
</button> <input type="hidden" name="submit_form" value="<?php echo session_id()"/>

I would use sprintf when parsing up the query. It eliminates SQL Injections. You can do something like this:

      $query = sprintf('SELECT * FROM TABLE WHERE username = "%s" AND password = "%s"',
      mysql_real_escape_string($username),
      mysql_real_escape_string($password));

Hopefully this works for you.