sed命令仅替换匹配的括号内的内容

Question

I have some old code that looks like OldUtility.getList(obj) that has been refactored to be obj.getList() . I'm trying to write a sed command that will correctly refactor my code. So far, what I have is:

sed -i '' 's/\(OldUtility.getList(\)\(.*\))/\2.getList()/g'

The problem with this is that it greedily grabs the last closing parenthesis on the line. This means cases like the below do not work:
OldUtility.getList(obj).size()
or
someFunc(OldUtility.getList(obj), otherObj.otherFunc())

But I don't want it to be non greedy, because it also needs to handle cases like:
OldUtility.getList(otherObj.toObj()) -> otherObj.toObj().getList()

So the question is how do I get \\2 to be everything inside the parentheses of the OldUtility.getList(...) ?

Answer 1

If you don't want to capture closing parenthesis, you should use [^)]* instead of .* .

Tested with this:

echo "OldUtility.getList(otherObj.toObj()) OldUtility.getList(obj).size() someFunc(OldUtility.getList(obj), otherObj.otherFunc())" | sed -E 's/OldUtility.getList.([^)]*)\\)([\\)]*)/\\1\\2.getList()/g'

The command is sed -E 's/OldUtility.getList.([^)]*)\\)([\\)]*)/\\1\\2.getList()/g' .

Answer 2

you're making it more complicated than needed.

$ echo "OldUtility.getList(obj)" | sed -r 's/(OldUtility.getList\()[^)]*\)/\1)/'

OldUtility.getList()

I guess I misread the question for the argument extract

$ echo "OldUtility.getList(obj)" | sed -r 's/OldUtility(.getList\()([^)]*)\)/\2\1)/'

obj.getList()

it's better to capture the string values from the search pattern to eliminate typos and containing the values in one place.

It looks like I missed one more. This handles one more level, but gets complicated for sed to handle without lookahead.

$ echo "OldUtility.getList(otherObj.toObj())" | 
  sed -r 's/OldUtility(.getList\()([^)]+(\(\))?)/\2\1/'

otherObj.toObj().getList()

Answer 3

Since getList(...) may contain any level of nested parenthesis several times, you can't solve this problem with sed (There's no way to know which closing parenthesis is the good one). Here is a pattern you can use with Perl (that has the feature to match nested parenthesis):

OldUtility\.getList\(([^()]*+(?:\((?1)\)[^()]*)*+)\)

Details:

OldUtility\.getList\( # Note that the literal dot and parenthesis must be escaped
(            # open capture group 1
    [^()]*+  # all that is not a parenthesis (zero or more)
    (?:           # open a non capturing group
        \((?1)\)  # recursion with the capture group 1 subpattern
        [^()]*
    )*+           # repeat the non-capturing group (zero or more times)
)
\)

Example:

echo 'OldUtility.getList(otherObj.toObj().toString())' | perl -pe 's/OldUtility\.getList\(([^()]*+(?:\((?1)\)[^()]*)*+)\)/$1.getList()/g'