带有MS Access DELETE的经典ASP循环失败

Question

I have a simple loop where I extract two values from a csv string multiple times.

I then send the values to a DELETE routine. Like so:

cvsString = "aaa_bbb, ccc_ddd"
arrCvs = split( cvsString, ",")
for each pair in arrCvs
    valArray  = split(pair, "_")
    Call DeleteRow (valArray(0), valArray(1))
next

sub DeleteRow(col1Val, col2Val)
    sql = "DELETE * FROM tblName WHERE col1 = 'col1Val' AND col2 = 'col2Val'"
    dbh.Execute sql, rowsAffected
end sub

Apologies, I can't copy my code so you get psuedo-code and a few shortcuts. The code works .... except

The first request to DELETE succeeds but all others fail. rowAffected returns: 1, 0, 0, 0, 0, etc

Any ideas. I searched where I can with no results

Answer 1

Have the loop create one SQL, and execute it:

cvsString = "aaa_bbb, ccc_ddd"
arrCvs = split( cvsString, ",")
SQL = "DELETE * FROM tblName WHERE"
for each pair in arrCvs    
    valArray  = split(pair, "_")
    Vals = Vals & " or (col1 = '" & valArray(0) & "' AND col2 = '" & valArray(1) & "')"
next
dbh.Execute sql & Right(Vals, Len(Vals)-len(" or")) , rowsAffected

Answer 2

This happens because you put static value instead of adding the actual, dynamic, value of the variables you pass to the sub routine.

Proper way would be using parameters:

Set cmd = Server.Createobject("ADODB.Command")
Set cmd.ActiveConnection = dbh
cmd.CommandText = "DELETE * FROM tblName WHERE col1=? AND col2=?"
cmd.CommandType = adCmdText
cmd.Parameters.Append(cmd.CreateParameter("col1Val", 202, 1, 255, col1Val))//adVarWChar
cmd.Parameters.Append(cmd.CreateParameter("col2Val", 202, 1, 255, col2Val))//adVarWChar
cmd.Execute rowsAffected