C＃硒隐式等待

Question

I'm using selenium/firefox/c# to enter data into several fields in a webpage, and then submit it to the website by clicking a submit button. I have tried using ImplicitlyWait so that the program waits for the results page to load for a maximum of 45 seconds and then grab results from that page. I have it currently coded as this

driver.Manage().Timeouts().ImplicitlyWait(TimeSpan.FromSeconds(45));
driver.FindElement(By.Id("dnn_ctr1734_Professional_btnSubmit")).Click();

I'm putting the implicit wait before clicking the submit button, but even if it takes only 15 seconds for the page to load its not grabbing the results when it finally loads. Do I have the ImplicitWait in the right order?

Answer 1

The correct place to put an implicit wait is usually right after you initialize the driver. It basically acts as a default wait time for an action to complete.

There are several ways to solve your problem...

1. Use an Explicit wait with an expected condition to wait until your busy spinner is gone.

   var wait = new WebDriverWait(Driver.Instance, TimeSpan.FromSeconds(10)); wait.Until(driver => !driver.FindElement(By.Id("busySpinnerID")).Displayed);

2. Wait until a particular element is visible on the page

   var wait = new WebDriverWait(Driver.Instance, TimeSpan.FromSeconds(10)); wait.Until(driver => driver.FindElement(By.Id("knownElementId")).Displayed);

3. Use JavaScript to wait until the page has loaded

   var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(30)); wait.Until(driver1 => ((IJavaScriptExecutor)driver).ExecuteScript("return document.readyState").Equals("complete"));

Answer 2

You should use explicit wait, use code like below:

 new WebDriverWait(driver, TimeSpan.FromSeconds(45)).Until(ExpectedConditions.ElementExists((By.Id("dnn_ctr1734_Professional_btnSubmit"))));
 driver.FindElement(By.Id("dnn_ctr1734_Professional_btnSubmit")).Click();

Answer 3

I agree with Dmitry, the best way to deal with waits is with the explicit wait function. To make your life even easier, you can add this into an extension method so you're always going to be waiting for the element to exist before clicking. Example:

Class Actions {

        public static IWebDriver ClickOn(IWebDriver driver, string button) 
        {
            var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(30));
            wait.Until(ExpectedConditions.ElementExists(By.XPath(button)));
            driver.FindElement(By.XPath(button)).Click();
            return driver;
        }
}

Then your code can be as simple as

Actions.ClickOn(d, SignInButton);

And your code will still wait for the element to exist before clicking.