如何从列表更新项目属性？

Question

I have a generic list named mysoldier whose items has properties like height, weight etc. So after adding the soldiers (mysoldier.Add), I want to change the height of soldier. For that I used this:

 public void Increase Height() 
 { 
  for (int i = 0; i < mysoldier .Count; i++)
  { 
   if (this.mysoldier [i].height > 7) 
   { 
     this.mysoldier [i].height= 7; 
   } 
   else 
   {
    this.mysoldier [i].height+= 1; 
   } 
  } 

but this is not changing height of only one specific object instead it changes height of all soldiers added to the container.

  public void IncreaseHeight(int i) //#, or mysoldier.Count - 1 (I believe) for last
  {
    if (this.mysoldier [i].height > 7) 
    { this.mysoldier [i].height= 7; } 
    else { this.mysoldier [i].height+= 1; }
  }

But with this code I change only the height of the soldier which is previously created. So please anyone can point me what is wrong in the code?

Answer 1

Some tips:

If it's a list, don't call it "mySoldier", call it "mySoldiers". This can make you confuse. How are you creating these soldiers? Because... if you are creating then adding the same through a loop, you are adding the reference(memory address) to the list. If you change something in one, you change in all of them. If you just want to change the property for one specific item, just pass the index as a parameter to your function instead of using a for statement.

If you still have the problem going on, Let's try to solve it.