奇怪的pthread_mutex_t行为

Question

Consider the next piece of code -

#include <iostream>

using namespace std;

int sharedIndex = 10;
pthread_mutex_t mutex;

void* foo(void* arg)
{
    while(sharedIndex >= 0)
    {
        pthread_mutex_lock(&mutex);

        cout << sharedIndex << endl;
        sharedIndex--;

        pthread_mutex_unlock(&mutex);
    }

    return NULL;
}

int main() {

    pthread_t p1;
    pthread_t p2;
    pthread_t p3;

    pthread_create(&p1, NULL, foo, NULL);
    pthread_create(&p2, NULL, foo, NULL);
    pthread_create(&p3, NULL, foo, NULL);

    pthread_join(p1, NULL);
    pthread_join(p2, NULL);
    pthread_join(p3, NULL);

    return 0;
}

I simply created three pthreads and gave them all the same function foo , in hope that every thread, at its turn, will print and decrement the sharedIndex .

But this is the output -

10
9
8
7
6
5
4
3
2
1
0
-1
-2

• I don't understand why the process doesn't stop when sharedIndex reaches 0.
• sharedIndex is protected by a mutex . How come it's accessed after it became 0? Aren't the threads supposed to directly skip to return NULL; ?

EDIT

In addition, it seems that only the first thread decrements the sharedIndex . Why isn't every thread decrement the shared resource at it's turn? Here's the output after a fix -

Current thread: 140594495477504
10
Current thread: 140594495477504
9
Current thread: 140594495477504
8
Current thread: 140594495477504
7
Current thread: 140594495477504
6
Current thread: 140594495477504
5
Current thread: 140594495477504
4
Current thread: 140594495477504
3
Current thread: 140594495477504
2
Current thread: 140594495477504
1
Current thread: 140594495477504
0
Current thread: 140594495477504
Current thread: 140594478692096
Current thread: 140594487084800

I wish that all of the thread will decrement the shared source - Meaning, every contex switch, a different thread will access the resource and do its thing.

Answer 1

This program's behaviour is undefined.

You have not initialized the mutex. You need to either call pthread_mutex_init or statically initialize it:

pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;

You read this variable outside the critical section:

while(sharedIndex >= 0)

That means you could read a garbage value while another thread is updating it. You should not read the shared variable until you have locked the mutex and have exclusive access to it.

Edit:

it seems that only the first thread decrements the sharedIndex

That's because of the undefined behaviour. Fix the problems above and you should see other threads run.

With your current code the compiler is allowed to assume that the sharedIndex is never updated by other threads, so it doesn't bother re-reading it, but just lets the first thread run ten times, then the other two threads run once each.

Meaning, every contex switch, a different thread will access the resource and do its thing.

There is no guarantee that pthread mutexes behave fairly. If you want to guarantee a round-robin behaviour where each thread runs in turn then you will need to impose that yourself, eg by having another shared variable (and maybe a condition variable) that says which thread's turn it is to run, and blocking the other threads until it is their turn.

Answer 2

The threads will be hanging out on pthread_mutex_lock(&mutex); waiting to get the lock. Once a thread decrements to 0 and releases the lock, the next thread waiting at lock will then go about it's business (making the value -1), and same for the next thread (making the value -2).

You need to alter your logic on checking value and locking the mutex.

Answer 3

int sharedIndex = 10;
pthread_mutex_t mutex;

void* foo(void* arg)
{
    while(sharedIndex >= 0)
    {
        pthread_mutex_lock(&mutex);

        cout << sharedIndex << endl;
        sharedIndex--;

        pthread_mutex_unlock(&mutex);
    }

    return NULL;
}

According to this code sharedIndex is the shared resource for all the threads.

Thus each access to it (both read and write) should be wrapped by mutex. Otherwise assume the situation where all the threads sample sharedIndex simultaneously and its value is 1 .

All threads, then, enter the while loop and each one decreases sharedIndex by one leading it to -2 at the end.

EDIT

Possible fix (as one of the possible options):

bool is_positive;
do
{
    pthread_mutex_lock(&mutex);

    is_positive = (sharedIndex >= 0);
    if (is_positive)
    {
        cout << sharedIndex << endl;
        sharedIndex--;
    }

    pthread_mutex_unlock(&mutex);
}while(is_positive);

EDIT2

Note that you must initialize the mutex:

pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;