SQL Server 中具有相同列的多个 Where 子句

Question

We have the below query running in one of our stored procedures:

SELECT 
    WOffice AS office,
    RIGHT(JobTitle,4) JOBTITLE,
    SUM(ISNULL(rHours,0)) AS rcount,
    SUM(ISNULL(rdollars,0)) + SUM(ISNULL(amount,0)) AS rdollars,
    CAST (DATEADD(wk,DATEDIFF(wk,0,paydate),-1)AS DATE )AS [week] 
FROM 
    [dbo].[warehouse]
WHERE 
    paydate BETWEEN paydate AND DATEADD(DAY, 7, paydate)
    AND (paydate BETWEEN @WkStart AND @EzMaxDate)
    AND (PayDate BETWEEN @Seasonstart AND @SeasonEnd)
    AND SUBSTRING(JobTitle,1,1) LIKE '%[A-Z]%' 
GROUP BY
    WOffice, RIGHT(JobTitle, 4), DATEADD(wk, DATEDIFF(wk, 0, paydate), -1)

In this code, the paydate column is used in multiple where clauses. Is there a more efficient way to write the above logic in SQL?

Answer 1

The logic for paydate is fine. If SQL Server supported LEAST() and GREATEST() , you might be able to find other elegant solutions.

Handling multiple overlapping time periods is tricky. I cannot say that your logic is correct . But, if your intention is to get the overlap for the different periods, then it is correct.

As a note, the logic for JOBTITLE is overkill. Either:

JobTitle LIKE '[A-Z]%'

or:

LEFT(JobTitle, 1) BETWEEN 'A' and 'Z'

I prefer the first approach, even since I started to like LIKE again.