我可以正确关闭这个插座吗？

Question

For the most part, it works, however sometimes it doesn't, this code is ment to close the socket only if(input.equals("Done")){ , am i closing it correctly? , it seems to me, from the code that i'm trying to close it regardless? Can anyone confirm or correct it from me?

Socket socket1;
int portNumber = 4445;
socket1 = new Socket(InetAddress.getLocalHost(), portNumber);
BufferedReader br = new BufferedReader(new InputStreamReader(socket1.getInputStream()));
PrintWriter pw = new PrintWriter(socket1.getOutputStream(), true);

pw.println("Hello");
pw.println("Hello");
pw.println("Hello");
pw.println("Hello");

String input = br.readLine();
while ((input = br.readLine()) != null) {
    if(input.equals("Hi")){
        pw.println("Hello");
    }
    else  if(input.equals("Done")){
        break;
    }

    br.close();
    pw.close();
    socket1.close();
}

Answer 1

First of all, you're disposing your object inside while loop, so they will be disposed no matter the second message is received (you're skipping the first with line just before while loop). If the second message by any chance will be DONE, then you're going out of loop without any socket disposial, so they're still inside your memory. And, as many pointed in comments, you may have problem, if any of your objects throws exceptions. The correct version for this app would be:

Socket socket1 = null;
int portNumber = 4445;
BufferedReader br = null;
PrintWriter pw = null;
try
{
    socket1 = new Socket(InetAddress.getLocalHost(), portNumber);
    br = new BufferedReader(new InputStreamReader(socket1.getInputStream()));
    pw = new PrintWriter(socket1.getOutputStream(), true);

    pw.println("Hello");
    pw.println("Hello");
    pw.println("Hello");
    pw.println("Hello");

    String input = null;
    while ((input = br.readLine()) != null) {
        if(input.equals("Hi")){
            pw.println("Hello");
        }
        else  if(input.equals("Done")){
            break;
    }
}
finally
{
    if(br != null) br.close();
    if(pw != null) pw.close();
    if(socket1 != null) socket1.close();
}