函数只会多次返回一个值

Question

I have this function :

function get_content($text_to_match) {
    $query  = "SELECT * ";
    $query .= "FROM table_name ";
    $query .= "WHERE one_column_name LIKE '%{$text_to_match}%' OR another_column_name LIKE '%{$text_to_match}%'";
    $cont = mysqli_query($connection, $query);
    if($content = mysqli_fetch_assoc($cont)) {
        return $content;
    } else {
        return null;
    }
}

But when I call it like:

  <div>
      <?php
        for ($i = 1; $i < count(get_content("text_to_match")); $i++) {
          echo '<article>' .
                 '<h3>' . get_content("text_to_match")["string1"] . '</h3>'.
                 '<p>' . get_content("text_to_match")["string2"] . '</p>' .
               '</article>';
        }
      ?>
  </div>

I only get the first match in the DB repeated as many times as the number of found items.

Where have I gone wrong?

Answer 1

use this code then fetch data properly

 while($content = mysql_fetch_array($cont))
{
   return $content;

 }

Answer 2

Your logic is at fault. You are calling get_content function to get all matches for the loop, as well as to get individual elements out of the list. This is:

• bad logic - the 2nd use case doesn't make sense
• excessive - you shouldn't need to run a database query just to output an already retrieved result

What you probably want to do is:

foreach (get_content('text_to_match') as $content) {
    echo '<article>';
    echo '<h3>' . $content['string1']  . '</h3>';
    echo '<p>' . $content['string2'] . '</p>';
    echo '</article>';
}

Answer 3

With a few modifications in combination with tips from @ Anant and @ Unix One 's answer, I arrived at this working solution:

Function definition

  function get_content($text_to_match, $multiple=false) {
        $query  = "SELECT * ";
        $query .= "FROM table_name ";
        $query .= "WHERE one_column_name LIKE '%{$text_to_match}%' OR another_column_name LIKE '%{$text_to_match}%'";
        $cont = mysqli_query($connection, $query);
        if ($multiple) {
          $content_array = [];
          while($content = mysqli_fetch_array($cont)) {
            $content_array[] = $content;
          }
          return $content_array;
        } else {
          if($content = mysqli_fetch_assoc($cont)) {
            return $content;
          } else {
            return null;
          }
        }
   }

Function calls

<?php
  /* multiple items */
  foreach(get_content("text_to_match", true) as $content) {
    echo '<article>' .
           '<h3>' . $content["string1"] . '</h3>' .
           '<p>' . $content["string2"] . '</p>' .
         '</article>';
  }
?>

<?php
  /* one item */
  echo get_content("text_to_match")["string"];
?>