[英]Deadlock of threads java
I am new to threads and has come up with a deadlock example. 我是线程新手,并提出了一个死锁示例。 I tried to reproduce a deadlock scenario but the code worked fine without any problem. 我试图重现死锁情况,但是代码运行正常,没有任何问题。
Please guide as to where i am wrong. 请指导我哪里错了。 Below is the code snippet 下面是代码片段
package Practice;
public class Deadlock {
public static void main(String[] args) {
Deadlock a = new Deadlock();
Threadslock first = new Threadslock(a);
Threadslock second = new Threadslock(a);
first.setName("First");
second.setName("Second");
first.start();
second.start();
}
}
class Threadslock extends Thread
{
Deadlock lock ;
private String anotherLock = "";
Threadslock(Deadlock lo)
{
lock = lo;
}
public void run()
{
if(getName().equals("First"))
{
synchronized(lock)
{
synchronized(anotherLock)
{
try
{
Thread.sleep (2000);
}
catch(InterruptedException r)
{
}
System.out.println("First Thread");
System.out.println("Next Step in First");
}
}
}
else
{
synchronized(anotherLock)
{
synchronized(lock)
{
try{
Thread.sleep (2000);
}
catch(Exception e)
{
}
System.out.println("Second Thread");
System.out.println("Next Step in Second");
}
}
}
}
}
The output is like this : 输出是这样的:
First Thread 第一线程
Next Step in First 第一步下一步
Second Thread 第二线程
Next Step in Second 第二步
Both locks need to be shared in order to create a deadlock. 这两个锁都需要共享才能创建死锁。 Try this 尝试这个
package Practice;
public class Deadlock {
public static void main(String[] args) {
Deadlock l1 = new Deadlock();
Deadlock l2 = new Deadlock();
Threadslock first = new Threadslock("First", l1, l2);
Threadslock second = new Threadslock("Second", l2, l1);
first.start();
second.start();
}
}
class Threadslock extends Thread
{
Deadlock first;
Deadlock second;
String name;
Threadslock(String name, Deadlock first, Deadlock second)
{
this.name = name;
this.first = first;
this.second = second;
}
public void run()
{
synchronized(first)
{
try
{
Thread.sleep (2000);
}
catch(InterruptedException r)
{
}
synchronized(second)
{
System.out.println(name + " Thread");
System.out.println("Next Step in " + name);
}
}
}
}
EDIT: Added sleep between acquiring locks 编辑:添加获取锁之间的睡眠
As @Sean Bright suggested, you add sleep in wrong place. 正如@Sean Bright所建议的,您在错误的地方添加睡眠。
What's more, you have two anotherLock
instances in both thread, it will never deadlock since both Thread First and Second Thread can get its own anotherLock
. 而且,两个线程中都有两个anotherLock
实例,因为线程第一个和第二个线程都可以获取自己的anotherLock
,所以它永远不会死锁。 So you must let two threads share the same anotherLock. 因此,您必须让两个线程共享相同的anotherLock。
Please check the code below ,hope it helps. 请检查下面的代码,希望对您有所帮助。
public class Deadlock {
public static void main(String[] args) {
Deadlock a = new Deadlock();
String anotherLock = "";
Threadslock first = new Threadslock(a,anotherLock);
Threadslock second = new Threadslock(a,anotherLock);
first.setName("First");
second.setName("Second");
first.start();
second.start();
}
}
class Threadslock extends Thread
{
Deadlock lock ;
String anotherLock;
Threadslock(Deadlock lo, String anotherLock)
{
lock = lo;
this.anotherLock = anotherLock;
}
public void run()
{
if(getName().equals("First"))
{
synchronized(lock)
{
System.out.println("First Thread");
try {
Thread.sleep(2000);
} catch (InterruptedException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
synchronized(anotherLock)
{
try
{
Thread.sleep (2000);
}
catch(InterruptedException r)
{
}
System.out.println("Next Step in First");
}
}
}
else
{
synchronized(anotherLock)
{
System.out.println("Second Thread");
try {
Thread.sleep(2000);
} catch (InterruptedException e1) {
// TODO Auto-generated catch block
e1.printStackTrace();
}
synchronized(lock)
{
try{
Thread.sleep (2000);
}
catch(Exception e)
{
}
System.out.println("Next Step in Second");
}
}
}
}
}
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.