使用静态属性隐藏NLog返回类实例

Question

I am trying to break away direct dependency of NLog from my code. So if in the future i decided to use another logging library, it will be painless. What I did is as following,

 internal class Logger
{
    private NLog.Logger _NLogInstance;

    internal static Logger Instance
    {
        get
        {
            return new Logger();
        }
    }

    public Logger()
    {
        LogManager.ReconfigExistingLoggers();
        _NLogInstance = LogManager.GetCurrentClassLogger();
    }

    public void Trace(string message)
    {
        _NLogInstance.Trace(message);
    }

    public void Debug(string message)
    {
        _NLogInstance.Debug(message);
    }

    public void Info(string message)
    {
        _NLogInstance.Info(message);
    }

    public void Warn(string message)
    {
        _NLogInstance.Warn(message);
    }

    public void Error(Exception ex, string message)
    {
        _NLogInstance.Error(ex, message);
    }

    public void Fatal(Exception ex, string message)
    {
        _NLogInstance.Fatal(ex, message);
    }
}

As you can see, to use my Logger one only need to do so,

Logger.Instance.Fatal(ex, ex.Message);

So, the real implementation of NLog is somehow hidden from the user of Logger. If tomorrow I need to use Log4net, i will only need to change my implementation in Logger class.

Is there any potential problem of doing so? Because I don't see people doing this anywhere. Or are there any better way?

Answer 1

I totally agree with the comments. You probably won't need to switch to another logging library and if you do, it's because the new library is so clever and works in another way, why you will need to change your abstraction anyway.

If you insist on wrapping you Common Logging .NET instead. It's an abstraction on top of pretty much all of the major logging frameworks. This way you don't need to write the abstraction yourself.