Android 中的“/”附近的语法错误

Question

The below code in my project calls a function in my database class to insert two values into my sqlite database

    saveButton = (Button) findViewById(R.id.Save);
    saveButton.setOnClickListener(new View.OnClickListener( ) {
        @Override
        public void onClick(View v) {
            addCig = (EditText) findViewById(R.id.cigName );
            myDbHelper1.insertNewCig(addCig.toString(), fileName );     
        }
    });

Here is the insert into function. I am getting an error that reads (near "/": syntax error). Can anybody help me look into it and see what is wrong with my code.

public void insertNewCig(String name, String file)
{
    //DB_PATH = "/data/data/com.example.newdb/databases/"
    //DB_NAME = "cigarettes"
    String myPath = DB_PATH + DB_NAME;
    String row1 = "INSERT INTO " + myPath + " (" + KEY_FIRST + ", " +  KEY_LAST + ") VALUES(" + name + ", " + file + ")";
    myDataBase.execSQL(row1);

}

Answer 1

myPath should be the name of a table in your database, not the name and path of the database file. You also need to add single quotes around the values you are inserting, otherwise SQLite won't recognize that they are literal string values and not something else (eg column names). This is one of many reasons not to try to build raw SQL statements by hand in code.

Since you have a SQLiteDatabase , you may as well use its insert() methods instead of execSQL() . In that case you would give it a ContentValues instead of constructing a raw statement, which obviates the need to wrap the string values with single quotes.

ContentValues values = new ContentValues();
values.put(KEY_FIRST, name);
values.put(KEY_LAST, file);
myDataBase.insert(TABLE_NAME, null, values);