按钮单击不起作用，双击工作

Question

I'm working with android recyclerview. I have a button on each item. When I click first time to button, nothing happens but I click double to this button, it works. Bellow, this is my code:

public class NewsViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {

@BindView(R.id.image_news)
public ImageView imageNews;

@BindView(R.id.text_title_news)
public TextView textTitleNews;

@BindView(R.id.text_description_news)
public TextView textDescriptionNews;

@BindView(R.id.text_time)
public TextView textTime;

@BindView(R.id.button_share)
public Button buttonShare;

@BindView(R.id.button_save)
public Button buttonSave;

public NewsViewHolder(View itemView) {
    super(itemView);
    ButterKnife.bind(this, itemView);
    buttonShare.setOnClickListener(this);
    buttonSave.setOnClickListener(this);
}

@Override
public void onClick(View v) {
    if (v.getId() == buttonSave.getId()) {
        Log.e("clicked", "save");
    } else if (v.getId() == buttonShare.getId()) {
        Log.e("clicked", "share");
    }
}

}

Please help!!!

Answer 1

try out initializing each onclicklistener anonymously as follows:

buttonShare.setOnClickListener(new View.OnClickListener(){
   @Override
   public void onClick(View v) {
       //do something 

   }

});

buttonSave.setOnClickListener(new View.OnClickListener(){
   @Override
   public void onClick(View v) {
       //do something else

   }

});

If you want to avoid this, you can try using a switch case instead of the if statements

Answer 2

Try this code:

public class NewsViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {

@BindView(R.id.image_news)
public ImageView imageNews;

@BindView(R.id.text_title_news)
public TextView textTitleNews;

@BindView(R.id.text_description_news)
public TextView textDescriptionNews;

@BindView(R.id.text_time)
public TextView textTime;

@BindView(R.id.button_share)
public Button buttonShare;

@BindView(R.id.button_save)
public Button buttonSave;

public NewsViewHolder(View itemView) {
    super(itemView);
    ButterKnife.bind(this, itemView);
    buttonShare.setOnClickListener(this);
    buttonSave.setOnClickListener(this);
}

@Override
public void onClick(View v) {
    switch (v.getId()) {
        case R.id.button_share:
            Log.e("clicked", "share");
            break;
        case R.id.button_save:
            Log.e("clicked", "saved");
            break;
     }
}

Answer 3

Since you are using ButterKnife I would recommend you to use ButterKnife annotation for performing click actions on button

@OnClick({R.id.button_share, R.id.button_save})
public void onClick(View view) {
    switch (view.getId()) {
        case R.id.button_share:
            // Do something
            break;
        case R.id.button_save:
            // Do something
            break;
    }
}

And use switch instead of if, for better readability.