[英]Stored Procedure gives an error
I have a MSSQL stored procedure as below: 我有一个MSSQL存储过程如下:
ALTER procedure [dbo].[GetDataFromTable]
(
@rowval varchar(50),
@tablename varchar(50),
@oby varchar(50)
)
as
begin
EXEC('Select top (' + @rowval + ') * from '+@tablename+ 'ORDER BY '+@oby+' DESC')
end
On execution, it gives following error: Msg 156, Level 15, State 1, Line 1 Incorrect syntax near the keyword 'BY'. 执行时,它会出现以下错误:消息156,级别15,状态1,行1关键字“BY”附近的语法不正确。 I tried following also, still the same error: 我也试过跟着,仍然是同样的错误:
ALTER procedure [dbo].[GetDataFromTable]
(
@rowval varchar(50),
@tablename varchar(50),
@oby varchar(50)
)
as
begin
EXEC('Select top (' + @rowval + ') * from '+@tablename+ 'ORDER BY sno DESC')
end
Note: @rowval represents number of rows to be fetched, @tablename represents name of table, @oby represents column based on which ordering should be done. 注意:@rowval表示要获取的行数,@ tablename表示表的名称,@ oby表示基于应该进行排序的列。 Note: I am using ASP.Net with C# at frontend to fire this procedure and using MSSQL 2008 R2 Express Edition at the backend 注意:我在前端使用带有C#的ASP.Net来启动此过程并在后端使用MSSQL 2008 R2 Express Edition
Give some space after @tablename
and before ORDER
在 @tablename
之后和ORDER
之前给出一些空格
Declare @sql varchar(max)=''
SET @sql = 'Select top (' + @rowval + ') * from '+quotename(@tablename)+ ' ORDER BY sno DESC'
--^here
EXEC (@sql)
Also start using Print/Select
to debug the dynamic sql
也开始使用Print/Select
来调试dynamic sql
To add some security to this dynamic sql I will make the following changes 要为此动态sql添加一些安全性,我将进行以下更改
@rowval
as INT
将@rowval
设为INT
QUOTENAME
function in @tablename
parameter to avoid sql injection 在@tablename
参数中使用QUOTENAME
函数以避免sql注入 SP_EXECUTESQL
to execute the dynamic query instead of EXEC
将使用SP_EXECUTESQL
来执行动态查询而不是EXEC
Here is a correct way to do it 这是一种正确的方法
Declare @sql nvarchar(max)='',@tablename varchar(130), @rowval int
select @sql = 'Select top (@rowval) * from '+quotename(@tablename)+ ' ORDER BY sno DESC'
exec sp_executesql @sql,N'@rowval int',@rowval = @rowval
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.