[英]Rails 5, Rolify - removing role from user
I am really struggling to understand something that is fundamental to writing code in rails. 我真的很难理解在rails中编写代码的基础知识。 I don't know what it is to ask a more fundamental question, but i seem to be having similar problems repeatedly. 我不知道问一个更基本的问题是什么,但我似乎反复遇到类似的问题。
I have managed to setup rolify in my Rails 5 app. 我已经设法在我的Rails 5应用程序中设置rolify。 I use rolify to assign roles to users. 我使用rolify为用户分配角色。
Now, I'm trying to setup a function to remove roles from users after they are assigned. 现在,我正在尝试设置一个功能,以便在分配用户后删除用户的角色。
In my user index, I have; 在我的用户索引中,我有;
<% user.roles.each do |role| %>
<%= role.name.titleize %> <br>
<% end %>
That shows the roles that have been assigned. 这显示了已分配的角色。
Then, Im trying to add: 然后,我试图添加:
<%= link_to 'Destroy', role, method: :delete, data: { confirm: 'Are you sure?' } %>
My destroy method is defined in my assign_roles controller. 我的destroy方法在我的assign_roles控制器中定义。 It has: 它有:
def destroy
user = User.find(params[:users])
# role = AppRole.find(params[:roles])
assigned_role = user.roles
# user_roles = user.roles
# organisation = Organisation.first
# byebug
user.remove_role assigned_role.name, @current_user.organisation
flash[:notice] = "Successfully removed"
redirect_to action: :index
end
The routes are: 路线是:
resources :users, shallow: true do
scope module: :users do
resources :assign_roles
end
There isn't an assign_role.rb model. 没有assign_role.rb模型。 I just use a controller and a view. 我只是使用控制器和视图。
When I try to use the destroy role link in my user index, I get an error that says: 当我尝试在我的用户索引中使用destroy role链接时,我收到一条错误消息:
Couldn't find User with 'id'=
Can anyone see what I need to do to get the assign_roles#destroy action to work? 任何人都可以看到我需要做什么才能使assign_roles#destroy动作起作用?
My create action in the assign_roles controller works. 我在assign_roles控制器中的创建操作有效。 It has: 它有:
def create
user = User.find(params[:users])
role = AppRole.find(params[:roles])
# organisation = Organisation.first
@organisation = Organisation.find(@current_user.organisation)
# byebug
user.add_role role.display_name, organisation
flash[:notice] = "Successfully created"
redirect_to action: :index
end
Entire assign roles controller: 整个分配角色控制器:
class Users::AssignRolesController < ApplicationController
before_action :authenticate_user!
def index
# if @current_user.is_admin?
@app_roles = AppRole.all
# else
# @app_roles = AppRole.where(category: relevant_category)
# end
# if @current_user.is_admin?
@users = User.all
# else
# @users = current_user.organisation.users.select { |u| u.id != current_user.organisation.owner_id }
# end
end
def create
user = User.find(params[:users])
role = AppRole.find(params[:roles])
# organisation = Organisation.first
@organisation = Organisation.find(@current_user.organisation)
# byebug
user.add_role role.display_name, organisation
flash[:notice] = "Successfully created"
redirect_to action: :index
end
def show
# @users = User.joins(:profiles).where('profiles.organisation_id = ?' @current_user.organisation.id)
# @users = User.all
@current_user.organisation.users
end
def update
end
def destroy
user = User.find(params[:users])
# role = AppRole.find(params[:roles])
assigned_role = user.roles
# user_roles = user.roles
# organisation = Organisation.first
# byebug
user.remove_role assigned_role.name, @current_user.organisation
flash[:notice] = "Successfully created"
redirect_to action: :index
end
end
I CAN DO WHAT I WANT TO DO FROM THE CONSOLE - I CANT FIGURE OUT HOW TO DO IT FROM THE CODE 我可以做我想从控制台做什么 - 我不知道如何从代码中做到这一点
In the console, I can write: 在控制台中,我可以写:
u.remove_role :fff, Organisation.first
That then successfully removes the role. 然后成功删除该角色。
This is fine as a test, but in the code I'm trying to use current_user.organisation instead of Organisation.first. 这可以作为测试,但在代码中我试图使用current_user.organisation而不是Organisation.first。 My objective is to allow a user to manage roles on its own organisation only. 我的目标是允许用户仅管理自己组织中的角色。
In my assign roles controller, I have the destroy action copied above. 在我的assign roles控制器中,我有上面复制的destroy动作。
In my users index, I have an attempt to delete the assigned role from the user as: 在我的用户索引中,我尝试从用户删除指定的角色,如下所示:
<% user.roles.each do |role| %>
<table class="table table-bordered">
<tr>
<td><%= role.name.titleize %></td>
<td><%= link_to 'Remove role', role, method: :delete, data: { confirm: 'Are you sure?' } %></td>
The error says: 错误说:
undefined method `role_path' for #<#
I wonder if I need to give it something else in the path so that it can find the assign roles#destroy action? 我想知道我是否需要在路径中给它一些其他内容,以便它可以找到赋值角色#dumping action?
When I rake routes | 当我耙路线| grep assign, I can see: grep assign,我可以看到:
DELETE /assign_roles/:id(.:format) users/assign_roles#destroy
I tried changing the path in my users index to: 我尝试将用户索引中的路径更改为:
<% user.roles.each do |role| %>
<table class="table table-bordered">
<tr>
<td><%= role.name.titleize %></td>
<td><%= link_to 'Remove role', assign_role_path(user), method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
</table>
<% end %>
But then that gives this error: 但后来出现了这个错误:
Couldn't find User with 'id'=
I don't understand what this error means. 我不明白这个错误意味着什么。
Another clue 另一个线索
Right, so I can see where the problem arises. 是的,所以我可以看到问题出现的地方。 I'm out of ideas for how to fix it. 我不知道如何修复它。
In the console, I can successfully remove a user's role in the way I want to by doing this: 在控制台中,我可以通过以下方式成功删除用户的角色:
u.remove_role :sdfddd, Organisation.first
Organisation Load (2.0ms) SELECT "organisations".* FROM "organisations" ORDER BY "organisations"."id" ASC LIMIT $1 [["LIMIT", 1]]
Role Load (0.7ms) SELECT "roles".* FROM "roles" INNER JOIN "users_roles" ON "roles"."id" = "users_roles"."role_id" WHERE "users_roles"."user_id" = $1 AND "roles"."name" = $2 AND "roles"."resource_type" = $3 AND "roles"."resource_id" = $4 [["user_id", 4], ["name", "sdfddd"], ["resource_type", "Organisation"], ["resource_id", 1]]
(0.1ms) BEGIN
SQL (0.4ms) DELETE FROM "users_roles" WHERE "users_roles"."user_id" = $1 AND "users_roles"."role_id" = 6 [["user_id", 4]]
(1.6ms) COMMIT
In the code, my current destroy action from the assign roles controller, which says: 在代码中,我从assign角色控制器的当前销毁操作,其中说:
def destroy
# user = User.find(params[:users])
user = User.find(params[:id])
# role = AppRole.find(params[:roles])
assigned_role = user.roles
# user_roles = user.roles
organisation = Organisation.first
# organisation = Organisation.find(current_user.organisation)
# byebug
user.remove_role assigned_role.name, organisation
flash[:notice] = "Successfully created"
redirect_to root_path
end
shows this process in the log: 在日志中显示此过程:
User Load (1.3ms) SELECT "users".* FROM "users" WHERE "users"."id" = $1 ORDER BY "users"."id" ASC LIMIT $2 [["id", 4], ["LIMIT", 1]]
User Load (0.4ms) SELECT "users".* FROM "users" WHERE "users"."id" = $1 LIMIT $2 [["id", 4], ["LIMIT", 1]]
Organisation Load (0.7ms) SELECT "organisations".* FROM "organisations" ORDER BY "organisations"."id" ASC LIMIT $1 [["LIMIT", 1]]
Role Load (1.0ms) SELECT "roles".* FROM "roles" INNER JOIN "users_roles" ON "roles"."id" = "users_roles"."role_id" WHERE "users_roles"."user_id" = $1 AND "roles"."name" = $2 AND "roles"."resource_type" = $3 AND "roles"."resource_id" = $4 [["user_id", 4], ["name", "Role"], ["resource_type", "Organisation"], ["resource_id", 1]]
The second parameter is a "Role", where maybe it should be the name of the role (i think). 第二个参数是“角色”,也许它应该是角色的名称(我认为)。 Role is a table name. 角色是表名。
I'm not sure how to plug this in to make this work. 我不知道如何插入它来使这项工作。 Can anyone see how I can get code to process in the way I can do it in the console? 任何人都可以看到我如何能够以我在控制台中执行的方式处理代码?
NEXT ATTEMPT 下一步尝试
My new attempt at the destroy action in the assign_roles controller has: 我对assign_roles控制器中的destroy动作的新尝试有:
def destroy
# user = User.find(params[:users])
user = User.find(params[:id])
# role = AppRole.find(params[:roles])
assigned_role = user.roles
# user_roles = user.roles
# organisation = Organisation.first
organisation = Organisation.find(current_user.organisation)
# byebug
user.remove_role assigned_role, organisation
flash[:notice] = "Successfully created"
redirect_to root_path
end
I think the problematic line is this one: 我认为问题在于这一行:
assigned_role = user.roles
It should be the specific role that I am trying to destroy (from the user's array of assigned roles). 它应该是我试图销毁的特定角色(来自用户的指定角色数组)。
The log shows: 日志显示:
[["user_id", 4], ["name", "#<Role::ActiveRecord_Associations_CollectionProxy:0x007f887ddb9c98>"], ["resource_type", "Organisation"], ["resource_id", 1]]
The role shouldn't be an array. 该角色不应该是一个数组。 It should be a specific role. 它应该是一个特定的角色。 So, my next guess is to try adding the role to the link in my users index, which is now: 所以,我的下一个猜测是尝试将角色添加到我的用户索引中的链接,现在是:
<%= link_to 'Remove role', assign_role_path(user, role), method: :delete, data: { confirm: 'Are you sure?' } %>
Then, I need ideas for how I can rewrite the assigned_role line in my destroy action so that it knows which role I am trying to un-assign from the user. 然后,我需要有关如何在destroy操作中重写assigned_role行的想法,以便它知道我试图从用户取消分配的角色。
I don't have any good ideas for how to do that. 我对如何做到这一点没有任何好的想法。
# role = AppRole.find(params[:roles])
assigned_role = user.role
# user_roles = user.roles
Any ideas that might help push this thought forward? 任何可能有助于推动这一思想的想法?
You are looking to destroy the role for just one User, right? 你想要破坏一个用户的角色,对吧? So 所以
params[:users]
shouldn't be plural, and :users isn't a valid key for params. 不应该是复数,并且:用户不是params的有效密钥。
You're basically trying to 你基本上是想要
User.find(nil)
which fails with 失败了
ActiveRecord::RecordNotFound: Couldn't find User with 'id'=
You probably should use 你可能应该使用
User.find(params[:id])
声明:本站的技术帖子网页,遵循CC BY-SA 4.0协议,如果您需要转载,请注明本站网址或者原文地址。任何问题请咨询:yoyou2525@163.com.