Python无限循环同时确定文件大小

Question

I'm ending up with an infinite loop while trying to determine the size of the folders in the drive. Here is the code I'm using,

import os
from os.path import join, getsize
from sys import exit

filepath="P:\\GIS\\Data"

dirList=os.listdir(filepath)

for fname in dirList:   
    for root, dir, files in os.walk(filepath):

        print  root , sum([getsize(join(root, name)) for name in files]),
        print  "bytes in", len(files), "non-directory files"


print "All finished!"

I have tried saving the result in a variable but loop does not even reach to that step and starts looping infinitely Please could you advise me where it is going wrong?

Answer 1

filepath="P:\\GIS\\Data"

dirList=os.listdir(filepath)

for fname in dirList:   
    for root, dir, files in os.walk(filepath):

You want to walk through every directory tree inside "P:\\\\GIS\\\\Data" and that's what you do in your second loop. However, you're doing this for every directory inside this directory because you iterate over dirList first, and you aren't even using fname .

Thus, for every directory in dirList , you do the same print s all over again, which gives you the wrong impression of an infinite loop.

Try removing for fname in dirList: and your script should reach its end.

Answer 2

It's unlikely to be an infinite loop or recursion because of os.walk because

By default, walk() will not walk down into symbolic links that resolve to directories. Set followlinks to True to visit directories pointed to by symlinks, on systems that support them.

But you do have a nested loop and this probably creates the impression that your code is infinite looping.

You could simplify this to avoid the nested loop

for root, dir, files in os.walk("P:\\GIS\\Data"):

    print  root , sum([getsize(join(root, name)) for name in files]),
    print  "bytes in", len(files), "non-directory files"

this I believe will produce the desired result.