为什么我的应用程序崩溃了？ 我的代码有什么问题？

Question

char* szWords[] = { "caralho", "porra" };
if (IsGoldGrade(pObj)) //Ignore, its ok. //Crashing after i added the
{
    for (int x = 0; x < sizeof(szWords); x++) {
        if (strstr((strlwr((char*)szWords[x])), szChat)) {
            char szBuffer[256]; 
            sprintf(szBuffer, "You can't type %s", szWords[x]);
            Announce(pObj, szBuffer);
            memset(szBuffer, 0, 256);
            return;
        }
    }
}

Idk but I can't use this as "code" on stackoverflow.

Pastebin: http://pastebin.com/u8yit8Rw

PS: I can't use StrStrI because im using Visual Studio 2003.

Answer 1

Your for loop condition is wrong. You want to iterate the array of pointers to char.
Your loop for (int x = 0; x < sizeof(szWords); x++) continues while x < sizeof(szWords) . But sizeof(szWords) is not array length. It just says how many bytes your array occupies in memory. It is system dependant, however it is twice the size of pointer to char, so probably 8 or 16 bytes. You need to divide this size by size of the array element then you will get the proper array size.

Rewrite your for loop like this:

for (int x = 0; x < sizeof(szWords)/sizeof(szWords[0]); x++)

or if your compiler supports C++11 you can try range-based for:

for (const char *word : szWords)

Apart from that, if you are writing C++ code you really should use STL and other C++ features. For instance your array of strings should be declared as:

std::vector<std::string> words = { "caralho", "porra" };

or if your compiler doesnt support C++11 (then really change it...)

std::vector<std::string> words;
words.push_back("caralho");
words.push_back("porra");

for (std::size_t i = 0; i < words.size(); ++i) {
    // since you are using C string functions you will need word as C string
    const char *word = words[i].c_str();
    // do whatever you want with word
}

Also consider reading modern C++ book before writing code.

Answer 2

From the look of it, this is a function which checks if the user has written a prohibited word?

I'd replace char* szWords[]... with std::vector<std::string> to store the prohibited words, and use std::find to see if the input is in that list.

#include <algorithm>
#include <iostream>
#include <string>
#include <vector>

std::vector<std::string> bannedWords{"hamster", "elderberries", "etcetera"};

bool isBanned(const std::string &str) {
  return std::find(bannedWords.begin(), bannedWords.end(), str) != bannedWords.end();
}

int main() {
  std::cout << "Is 'wally' banned? " << isBanned("wally") << std::endl;
  std::cout << "Is 'elderberries' banned? " << isBanned("elderberries") << std::endl;
}

More information about std::find is here .

Here's an online demo