怪物大通pygame

Question

So here is my problem , I'm at the (very) beginning of making my Rogue like game and i'm stuck at making an enemy chase the player , it must be something easy and obvious but my skills are pretty low ... So here is my Monster class

class monster():
  def __init__(self , mright, mleft, mup, mdown):
    self.mright = pygame.image.load(mright).convert_alpha()
    self.mleft = pygame.image.load(mleft).convert_alpha()
    self.mup = pygame.image.load(mup).convert_alpha()
    self.mdown = pygame.image.load(mdown).convert_alpha()

    self.sqrx = 7 
    self.sqry = 2
    self.x = 210
    self.y = 60
    self.direction = self.mdown

    char = character(right , left , up , down , Level)

def chase(self,direction):
    if self.sqrx > char.sqrx :
        self.sqrx -= 1
        self.x = self.sqrx * size_sprite 
    self.direction = self.mleft

    if self.sqrx < char.sqrx :
        self.sqrx += 1
        self.x = self.sqrx * size_sprite 
    self.direction = self.mright

    if self.sqry > char.sqry :
        self.sqry -= 1
        self.y = self.sqry * size_sprite
    self.direction = self.mup

    if self.sqry < char.sqry :
        self.sqry += 1
        self.y = self.sqry * size_sprite
    self.direction = self.mdown

And the Game Loop

while gameon:


    pygame.time.Clock().tick(30)

    for event in pygame.event.get():

        if event.type == QUIT:
            gameon = 0
            on = 0

        elif event.type == KEYDOWN:

            if event.key == K_ESCAPE:
                gameon = 0

            elif event.key == K_RIGHT:
                char.move('right')  
            elif event.key == K_LEFT:
                char.move('left')
            elif event.key == K_UP:
                char.move('up')
            elif event.key == K_DOWN:
                char.move('down')

    level.display(window)
    window.blit(monst.direction , (monst.x , monst.y))
    window.blit(char.direction , (char.x , char.y))
    pygame.display.flip()

Answer 1

You should use chase() in mainloop - see comment in code

while gameon:

    pygame.time.Clock().tick(30)

    # --- events ---

    for event in pygame.event.get():

        if event.type == QUIT:
            gameon = 0
            on = 0

        elif event.type == KEYDOWN:

            if event.key == K_ESCAPE:
                gameon = 0

            elif event.key == K_RIGHT:
                char.move('right')  
            elif event.key == K_LEFT:
                char.move('left')
            elif event.key == K_UP:
                char.move('up')
            elif event.key == K_DOWN:
                char.move('down')
        # - object events ---

        # char.handle_event(event)

    # --- updates ---

    # HERE put all functions which change elements
    #      (but don't depend on events) like:
    # - chasing player, 
    # - moving mosters, 
    # - detecting collisions, 
    # - animating other elements (ie. fire, water, etc.)

    # --- draws all elements ---

    level.display(window)
    window.blit(monst.direction , (monst.x , monst.y))
    window.blit(char.direction , (char.x , char.y))
    pygame.display.flip()

See some templates of PyGame code

---

In Moster I would use char (player instance) as argument in

def __init__(self , char, ...):
    self.char = char

to have access to its position all the time

or at least

def chase(self, direction, char):

to have access to player when you call chase()

---

BTW: instead of gameon = 0 more readable is gameon = False (and gameon = True )

---

You could create draw() in Moster() and do

 monst.draw(window)

instead of

 window.blit(monst.direction , (monst.x , monst.y))

---

Use CamelCase names for classes ( class Monster(): ) and lower_case names for variables ( moster = Moster() ). It makes code more readable. See PEP 8 -- Style Guide for Python Code

Answer 2

Like someone mentioned above - your indentation of setting the direction is causing it to call all 4 of the assignments every time chase is called. This essentially always sets direction = self.mdown

def chase(self,direction):
    if self.sqrx > char.sqrx :
        self.sqrx -= 1
        self.x = self.sqrx * size_sprite 
        self.direction = self.mleft