丢人 // Node＆Passport的未处理“错误”事件

Question

I'm trying to build a user authentication system into my Node app with Passport.js. When I try to sign up as a new user, it seems to work fine. But when I try logging in, the command prompt gives me this:

  throw er; // Unhandled 'error' event
  ^

TypeError: done is not a function
    at C:\spectray\config\passport.js:55:22
    at C:\spectray\node_modules\mongoose\lib\model.js:3419:16
    at C:\spectray\node_modules\kareem\index.js:212:48
    at C:\spectray\node_modules\kareem\index.js:127:16
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Here's my passport.js file:

var passport = require('passport'), LocalStrategy = require('passport-local').Strategy;

var User = require('../app/models/user');

passport.serializeUser(function(user, done) {
    done(null, user.id);
});

passport.deserializeUser(function(id, done) {
    User.findById(id, function(err, user) {
        done(err, user);
    });
});

passport.use('local-signup', new LocalStrategy({

    passReqToCallback : true
},

    function(req, email, password, done) {

        process.nextTick(function() {

            User.findOne({ 'local.email' : email}, function(err, user) {
                if (err)
                    return done(err);

                if (user) {
                    return done(null, false, req.flash('signupMessage', 'That email is already taken.'));
                } else {

                    var newUser = new User();

                    newUser.local.email = email;
                    newUser.local.password = newUser.generateHash(password);

                    newUser.save(function(err) {
                        if (err)
                            throw err;
                        return done(null, newUser);
                    });
                }
            });
        });
}));

passport.use(new LocalStrategy({

    passReqToCallback : true
},

function(username, password, done) {

    User.findOne({ username: username }, function(err, user) {
        if (err) { return done(err); }
        if (!user) {
            return done(null, false, { message: 'Incorrect username.' });
        }
        if (!user.validPassword(password)) {
            return done(null, false, { message: 'Incorrect password.' });
        }
        return done(null, user);
    });
}
));

And here's my server.js file:

var express = require('express');
var app = express();
var port = process.env.PORT || 8080;
var mongoose = require('mongoose');
var passport = require('passport');
var morgan = require('morgan');
var cookieParser = require('cookie-parser');
var bodyParser = require('body-parser');
var session = require('express-session');
var flash = require('connect-flash');
var db = require('./config/database.js');
var favicon = require('serve-favicon');

app.use(favicon(__dirname + '/public/imgs/favicon.ico'));

mongoose.Promise = global.Promise;

mongoose.connect(db.url);
require('./config/passport');

app.use(morgan('dev'));
app.use(cookieParser());
app.use(bodyParser.urlencoded({ extended: true }));
app.use(bodyParser.json());

app.set('view engine', 'ejs');

app.use(session({ secret: 'penniesfromheaven', resave: true, saveUninitialized: true }));
app.use(passport.initialize());
app.use(passport.session());
app.use(flash());

app.use(express.static(__dirname + '/public'));

require('./app/routes.js')(app, passport);

app.listen(port);
console.log('The magic happens on port ' + port);

I tried deleting my node_modules folder and running npm install, but this error still shows up. What am I doing wrong?

Answer 1

Because you are setting the passReqToCallback option to true in the LocalStrategy constructor, your callback function gets called with these arguments: (req, username, password, done) , but your function is accepting (username, password, done) , which is why the arguments are getting assigned to the wrong parameters (and thus why done isn't a function as the error message says). To fix this, try removing the passReqToCallback option, like this:

passport.use(new LocalStrategy(function(username, password, done) {

    User.findOne({ username: username }, function(err, user) {
        if (err) { return done(err); }
        if (!user) {
            return done(null, false, { message: 'Incorrect username.' });
        }
        if (!user.validPassword(password)) {
            return done(null, false, { message: 'Incorrect password.' });
        }
        return done(null, user);
    });
}));

Or, if you decide later that you need the req in your LocalStrategy, then add the parameter to the function, like this:

passport.use(new LocalStrategy({

    passReqToCallback : true
},

function(req, username, password, done) {

    User.findOne({ username: username }, function(err, user) {
        if (err) { return done(err); }
        if (!user) {
            return done(null, false, { message: 'Incorrect username.' });
        }
        if (!user.validPassword(password)) {
            return done(null, false, { message: 'Incorrect password.' });
        }
        return done(null, user);
    });
}
));