在SQL语句中使用范围值作为参数

Question

I am connecting to a database via ODBC. I have the SQL Statement written in VBA. I have defined three parameters to pass, defined as cell references:

Dim Param1 As String
Dim Param2 As String
Dim Param3 As String

Param1 = Sheets("SHEET1").Range("P1").Value
Param2 = Sheets("SHEET1").Range("P2").Value`
Param3 = Sheets("SHEET1").Range("P3").Value

The between clause of the Where Statement works fine (Tables are examples) This is the end of the Statement:

(VPXXX.PDXXX Between " + Param1 + " and " + Param2 + "))"

When I try to add an "equal' Statement at the end, I throw an error "General ODBC Error:

AND ((VPXXX.PDXXX=" + Param3 + " ))"

Note: The Below end works

AND ((VPXXX.PDXXX='LDPDQ'))"

It just hard codes a single vendor

Hope this is enough info ..... First time building a query in SQL. thanks in Advance

Answer 1

Assuming your cell value itself isn't enclosed in single-quotation marks, you probably need to change

AND ((VPXXX.PDXXX=" + Param3 + " ))"

to include the quotation marks, ie

AND ((VPXXX.PDXXX='" + Param3 + "' ))"

Answer 2

As said by @YowE3K, you were missing ' to enclose your values, so your code should be :

"VPXXX.PDXXX Between '" + Param1 + "' and '" + Param2 + "')"

and

"AND (VPXXX.PDXXX='" + Param3 + "')"

---

Btw, if you are using any IN statement in you SQL query, this could come in very handy :

Public Function ConcatSQL(RgToConcat As Range, Optional AllowMultipleS As Boolean = False) As String
Dim CelRg As Range
ConcatSQL = "('"
For Each CelRg In RgToConcat.Cells
    If CelRg.Value <> vbNullString And (InStr(1, ConcatSQL, CelRg.Value) = 0 Or AllowMultipleS) Then
        ConcatSQL = ConcatSQL & CelRg.Value & "', '"
    End If
Next CelRg
ConcatSQL = Left(ConcatSQL, Len(ConcatSQL) - 3) & ")"
End Function

How to use :

"VPXXX.PDXXX IN " & ConcatSQL(Sheets("SHEET1").Range("P1:P3"))