无法输出Line C ++的对象点

Question

Hi I have the following code where i have to pass object Point into line and provide the X & Y Output for the line with it's point. however the output of my code is -842150451 for all the X and Y co-ordinates, alternatively i can output just the two points however i am unsure how to do this.

Note: I cannot pass integers into Line, i need to place Object Point into line. Note*: i need to use a vector to store 10 lines with random points.

    // Creates randomly generated points on a number plane and generates lines between them.

#include <vector>
#include <iostream>

#include "Point.h"
#include "Line.h"

int main(){
    vector<Line> lineVector;
    int i;
    int counter = 1;
    Point p1;
    Point p2;
    Line *line;
    line = new Line;

    for (i = 0; i < 10; i++){
        p1.pCreate();
        p2.pCreate();
        lineVector.push_back(*line);
    }

    vector<Line>::iterator it;
    for (it = lineVector.begin(); it != lineVector.end(); ++it){
        cout << "line " << counter << endl;
        counter++;
        it->printLine();
        cout << endl;
    }

    system("PAUSE");
    return 0;
}
#ifndef __Point__
#define __Point__

#include<iostream>
#include<stdio.h>

using namespace std;

class Point{
private:
    int x, y;
public:
    Point();
    int getYPos(){ return y; }
    int getXPos(){ return x; }
    void pCreate();
};
#endif

Point::Point(){
    int x = 0, y = 0, pnumber = 0;
}

void Point::pCreate(){
    x = -50 + rand() % 100;
    y = -50 + rand() % 100;
}

#ifndef __Line__
#define __Line__

#include <iostream>
using namespace std;

class Line{
private:
    Point a, b;
public:
    Line();
    ~Line(){}
    void printLine();
};
#endif

Line::Line(){

}

void Line::printLine(){
    cout << "point1 x: " << a.getXPos() << "y: " 
        << a.getYPos() << endl
        << "point2 x: " << b.getXPos() << "y: "
        << b.getYPos() << endl;
}

Answer 1

I think you need to review your code,

    for (i = 0; i < 10; i++){
    p1.pCreate();
    p2.pCreate();
    lineVector.push_back(*line);
}

This loop pushed one line 10 times in a vector?!?

Answer 2

Hi thanks for for the answer, i was creating 10 lines and storing them in a vector. I then printed out the vector. all fixed now =)

include

include

include "Point.h"

include "Line.h"

int main(){ vector lineVector;

Point p;
int i;
int counter = 1;

for (i = 0; i < 10; i++){
    p.pCreate();
    Point p1(p.getXPos(), p.getYPos());
    p.pCreate();
    Point p2(p.getXPos(), p.getYPos());
    Line line(p1, p2);
    // input point into line
    lineVector.push_back(line);
}

vector<Line>::iterator it;
for (it = lineVector.begin(); it != lineVector.end(); ++it){
    cout << "line " << counter << endl;
    counter++;
    it->printLine();
    cout << endl;
}

system("PAUSE");
return 0;

}