如何缩短此重复的C＃TextBox.Clear代码？

Question

Been reading through the threads a lot recently as I am learning to code!

In essence all I know is self taught and very basic, so I would like to start becoming more professional

I would like to shorten this code down (in the simplest way possible) since I often end up with very repetitive code! Here is a primary example

private void button2_Click(object sender, EventArgs e)
    {
        textBox1.Clear();
        textBox2.Clear();
        textBox3.Clear();
        textBox4.Clear();
        textBox5.Clear();
        textBox6.Clear();
        textBox7.Clear();
        textBox8.Clear();
        textBox9.Clear();
        textBox10.Clear();
        textBox11.Clear();
        textBox12.Clear();
    }

For context I can't clear all textboxes on my form since textBox13 always has a useful value that I can't have deleted! EDIT * textBoxes 1 to 6 are in groupBox1 , and textBoxes 7-12 are in groupBox2 . This appears to be significant; I was just using the groupbox tool to make the program clear!

If anyone can help I would be truly grateful! Please keep in mind I am still a coding novice, so some features I am unfamiliar with.

Here is an image of the program to help!

Answer 1

Assuming all your textboxes name start in the format you displayed, you could use this:

        foreach (Control control in Controls)
        {
            if (control.Name.StartsWith("textBox") && !control.Name.EndsWith("13") && control.GetType() == typeof(TextBox))
            {
                TextBox textBox = (TextBox)control;
                textBox.Clear();
            }
        }

---

EDIT

If you want it to work with group boxes use this code by calling ClearTextBoxes (just write "ClearTextBoxes();")

    private void ClearTextBoxes()
    {
        foreach (Control control in Controls)
        {
            ClearTextBox(control);
        }
    }

    private void ClearTextBox(Control control)
    {

        if (control.GetType() == typeof(TextBox))
        {
            if (control.Name.StartsWith("textBox") && !control.Name.EndsWith("13"))
            {
                TextBox textBox = (TextBox)control;
                textBox.Clear();
            }
        }
        else if (control.GetType() == typeof(GroupBox))
        {
            GroupBox groupBox = (GroupBox)control;

            foreach (Control groupBoxControl in groupBox.Controls)
            {
                ClearTextBox(groupBoxControl);
            }

        }
    }

Answer 2

The current setting doesn not allow you to clear everything quickly because each variable, even if they're all of the same type and with similar name, is a different entity and you cannot iterate through them.

Anyway, you could group them in an array and iterate through them like this:

// Fill this array in an Init function
YourType[] textBoxes;

private void button2_Click(object sender, EventArgs e)
{
    // Iterate through the whole array except for the last element
    for(int i=0; i<textBoxes.Length-1; i++)
    {
        textBoxes[i].Clear();
    }
}

Answer 3

One possible solution would be store textboxes in list

List<TextBox> textBoxes

And then iterate through this collection using for or foreach loop and calling Clear() method.

Or use extension method ForEach()

textBoxes.ForEach(x => x.Clear());

Answer 4

The simplest way is to prepare a collection containing all of your textbox objects

var textBoxes = new List<TextBox> { textBox1,textBox2,textBox3};// fill in the rest

and just iterate with a 'foreach' on it

textBoxes.ForEach(textBox => textBox.Clear());

This is a simple suggestion. You can also use reflection to make it more implicit but it doesn't worth it

Answer 5

Usually having too many of certain control can be a sign that you can consider a different type of control, but that doesn't seem to be the case based on the screenshot. You can use array:

foreach (var t in new[] { textBox1, textBox2, textBox3 })
    t.Clear();

If the controls are directly in the form then something like:

foreach (Control c in this.Controls)
    if (c is TextBox && c.Name != "textBox13")
        c.Text = "";                            // .Text = "" is what TextBox.Clear() does

but because the controls are inside other controls:

foreach (Control c in this.groupBox1.Controls) if (c is TextBox) c.Text = ""; 
foreach (Control c in this.groupBox2.Controls) if (c is TextBox) c.Text = ""; 

or:

foreach (var gb in new[] { groupBox1, groupBox2 })
    foreach (Control c in gb.Controls)
        if (c is TextBox) c.Text = "";