Rails 5 API - 服务

Question

I refactored one of my controllers to move the update logic into a service

so the controller looks like this

  #user_controller.rb
  def update
    UserManagement::UserUpdatePassword.new(@user, user_params).call
  end

  def user_params
    params.require(:user).permit(:password, :password_confirmation)
  end

  def get_user
    @user ||= User.find_by_password_reset_token(params[:id])
  end

So as I said before I moved the entire logic into a service that takes care of the update logic and the redirects. I know there might be a debate in leaving the redirects in the controller.

#user management service
module UserManagement
 class UserUpdatePassword
  attr_reader :user, :params

  def initialize(get_user, user_params)
    @user = get_user
    @params = user_params
  end

  def call
    if user.password_reset_token < 2.hours.ago
      redirect_to new_password_reset_path, :alert => "Password reset has expired."
    elsif user.update_attributes(params)
      redirect_to confirmation_password_resets_path, :notice => "Congratulations! Your Password has been reset."
    else
      render :edit
    end
  end
 end
end

If I use the Awesome Print in the call method I can the user and params properly being passed but I'm getting a

NoMethodError (undefined method "build_notice" for nil:NilClass):

and I can't figure out why

Answer 1

Looks like it caused by airbrake gem. You should add environment condition to airbrake (or errbit) initializer.

config/initializers/airbrake.rb

if Rails.env.production?
  Airbrake.configure do |config|
    # your configuration here
  end
end

and add gem airbrake to the production group.

Gemfile

group :production do
  gem 'airbrake'
end