Selenium + Python：for ..（循环）无法按预期工作

Question

Here is my code. What I am trying to do is to print all hotel names in all pages with the search term "BERLIN, GERMANY". While I press the 'run' button in Pycharm there is nothing printed in screen. Can anyone figure out what is the mistake in my code?

from selenium import webdriver    
from selenium.webdriver.common.by import By    
from selenium.webdriver.support import expected_conditions as EC    
from selenium.webdriver.support.wait import WebDriverWait

my_list = []

driver = webdriver.Chrome("C:\\Python27\\selenium\\webdriver\\chrome\\chromedriver.exe")

driver.get('http://booking.com')

driver.find_element_by_css_selector("input#ss").send_keys("BERLIN, GERMANY")

driver.find_element_by_css_selector("button.sb-searchbox__button").click()

hotel_name = driver.find_elements_by_css_selector(".sr-hotel__name")

visible_next=driver.find_element_by_css_selector(".paging-next")

driver.maximize_window()

for link in hotel_name:

        scrap_hotel_name = link.text

        print (scrap_hotel_name)

        my_list.append(scrap_hotel_name)

        while True:

            click_icon = WebDriverWait(driver, 4).until(EC.visibility_of_element_located([By.LINK_TEXT, 'Next page']))

            click_icon.click()

Answer 1

There are couple of issues in the logic of your script:

1. Your hotel_name defined out of loop. That means that you gets the list of elements just once- on the first page only;
2. Your visible_next variable defined, but you don't use it;
3. The while loop inside for loop intents to click "Next" button time after time without executing the rest of for loop lines (they will be executed only once- on the first page)

Try below code to get hotel names from all of the pages:

from selenium import webdriver
from selenium.webdriver.common.by import By
from selenium.webdriver.support import expected_conditions as EC
from selenium.webdriver.support.wait import WebDriverWait 

driver = webdriver.Chrome()
driver.get('http://booking.com')
driver.find_element_by_css_selector("input#ss").send_keys("BERLIN, GERMANY")
driver.find_element_by_css_selector("button.sb-searchbox__button").click()
my_list = []

while True:
    WebDriverWait(driver, 5).until(EC.invisibility_of_element_located([By.CSS_SELECTOR, 'div[class^="sr-usp-overlay"]']))
    my_list.extend([hotel.text for hotel in driver.find_elements_by_css_selector('.sr-hotel__name')])
    try:
        WebDriverWait(driver, 5).until(EC.element_to_be_clickable([By.CSS_SELECTOR, "*[data-page-next]"])).click()
    except:
        break

[print(hotel) for hotel in my_list]

In Python 2.x replace last line with

for hotel in my_list:
    print(hotel)