es6中lodash的findIndex

Question

I always depends on findIndex of lodash and splice to rerender my updated data, I'm looking to ditch lodash as I'm compiling with babel now, what can be done to improve below code?

onDoneUpdatedUserStatus(user) {

    //this.users means existing array of object of existing users

    const index = findIndex(this.users, { user_id: user.user_id });
    if (index > -1) {
        this.users.splice(index, 1, user);
    }
}

Answer 1

You can store your users in a Map from user ids to users instead of an array. Then you just need to write

this.users.delete(user.user_id);

This will also speed up your lookup time.

Answer 2

JS Array also has a findIndex method which is useful:

onDoneUpdatedUserStatus(user) {
    const index = this.users.findIndex(u => u.user_id === user.user_id);
    if (index > -1) {
        this.users.splice(index, 1, user);
    }
}

Answer 3

这里是单线：

this.users = this.users.map(oldUser => oldUser.id === user.id ? user : oldUser);