Javascript促销代码提示-无尽的while循环

Question

We're using a promo code to allow people access to a page. It doesn't have to be secure - just trying to give the customers a code prompt to make them feel special.

So I used this code... obviously I am doing something wrong because the browser keeps checking for the code even after they entered it (and eventually the page crashes). I tried break; at the end, but then prompt doesn't happen.

I would appreciate any help with this.

All I want to do is get rid of the endless loop here.

 var secret; while (secret !== "1") if (secret !== "2") if (secret !== "3") if (secret !== "4") { secret = prompt("What is the secret password?"); }; 

Answer 1

The problem is improper use of while mixed with if . Maybe you should consider an other approach:

 var askSecret = function askSecret() { var secret = prompt("What is the secret password?"); if(secret !== "theSecret") { askSecret(); } }; askSecret(); 

Edit: multiple passwords/secrets

In the previous example, the only valid secret/password is "theSecret". If you need to have more than one secret/password, you'll have to extend the conditional with an AND && operator:

 var askSecret = function askSecret() { var secret = prompt("What is the secret password?"); if( secret !== "theSecret" && secret !== "TheOtherSecret" && secret !== "TheThirdValidSecret" ) { askSecret(); } }; askSecret(); 

Answer 2

Your code goes into an infinite loop if the user types any of the numbers in the if (secret != XX) lines. This is because the while condition is met, but the if condition fails, so it skips over the prompt() function and repeats the while . Since this doesn't change answer , it keeps doing this over and over.

If you want to check for multiple possible answers, do them all in the while statement:

 var secret; while (secret != "1" && secret != "2" && secret != "3" && secret != "4") { secret = prompt("What is the secret password"); }