ASP.NET控制器+实体框架上下文=线程安全吗？

Question

All,

I am writing code that looks like:

public class UserController : AuthenticatedController
{

    private MunicipalContext db = new MunicipalContext();

    // GET: Users/Edit/5
    public ActionResult Edit(int? id)
    {
        //Do stuff with db.Users
    }

    // Other action methods that do stuff with db.Users
}

Coming from a Java background, this feels like Servlets and instance fields and is starting to raise that buzzing feeling in the back of my head.

Am I going to run into thread safety issues?

Answer 1

Each controller will be created once per request, they are not singletons. No instance member is shared between threads.

So the answer is no, there is no threading issue with your code, each time a new request to an action of your UserController is made a new UserController and a new MunicipalContext are created.

A side note: remember to Dispose() your MunicipalContext instance when is no longer used. More info here .

Answer 2

You don't have any thread-safety issues, but typically you would use a slightly different pattern with ASP.NET MVC where the context is injected into the controller using IoC to achieve a context-per-request pattern

The problems would arise if your controller consume some services which are also doing database acccess - if you don't share the context between them you can get some odd and/or incorrect behaviour.

The IoC container can then perform the dispose on the context after the request is processed; how you actually do this depends on whether you are using traditional ASP.NET (via a HttpModule) or Owin (middleware component)