具有多个更新的SQL Server（t-sql）存储过程

Question

I have been writing a stored procedures. But now I'm unsure whether I'm doing it properly. I have this code:

BEGIN
    UPDATE tblPro 
    SET Email = @p_Email 
    WHERE ProID = @p_proId

    UPDATE tblVisits 
    SET VisitBrief = 'CONFIRMED' 
    WHERE VisitID = @p_visitId

    UPDATE Bookings 
    SET JobConfirmation = 1 
    WHERE BookingID = @p_bookingId

    IF @@ROWCOUNT > 0
    BEGIN
        INSERT INTO tblView (ViewLogType)
        VALUES ('Visit')
    END
    ELSE
        PRINT 'WARNING: Insert Failed' 
END

Is it better to have @@ROWCOUNT > 0 after every update statement just to make sure that all the statements are executed?

Thanks for advice

Answer 1

If you want to catch errors, you could use TRY/CATCH.

If you want to save the rowcounts for later followup, you should log them for the statements that you are interested in saving. Rowcount could still be zero even if the statement is executed correctly (0 rows were affected).

You can also use a transaction if you want to be able to rollback if one of the statements fails.