如何使用REST API优化请求JSON的C＃代码

Question

I have to make ac# application which uses REST api to fetch JIRA issues. After I run the tool I am getting the correct output but it is taking a lot of time to display the output. Below is the part of code which is taking the maximum time

var client =new WebClient();

foreach(dynamic i in jira_keys)
{
 issue_id=i.key;
 string rest_api_url="some valid url"+issue_id;
 var jira_response=client.DownloadString(rest_api_url);

 //rest of the processing
}

jira_keys is a JArray. After this there is processing part of the JSON in the for each loop. This is taking a lot of time as the number of jira_keys increase. I cannot apply multi-threading to this since there are shared variable issues. So please someone suggest some way to optimise this.

Answer 1

If the issues are tied to a specific project or some other grouping, you can instead search for issues with a JQL string. This way you get them in bulk and paginated.

https://docs.atlassian.com/jira/REST/cloud/#api/2/search-search

Also, like cubrr said in his comment, async calls should work fine if you want to make api calls with multiple threads. Awaiting the call will block until the shared resources are ready.

(Would have posted as a comment if I had enough rep)

Answer 2

Here is an example of how you can fetch the responses from JIRA asynchronously.

var taskList = new List<Task<string>>();
foreach (dynamic i in jira_keys)
{
    issue_id = i.key;
    string rest_api_url = "some valid url" + issue_id;
    var jiraDownloadTask = Task.Factory.StartNew(() => client.DownloadString(rest_api_url));
    taskList.Add(jiraDownloadTask);
}
Task.WaitAll(taskList.ToArray());

//access the results
foreach(var task in taskList)
{
    Console.WriteLine(task.Result);
}