从Rails 5.0.0.1中的日期范围生成几个模型行

Question

I want to generate several scheduled events from a date range on selected days input in a form for a specific trainer, The Evento model is:

class Evento < ApplicationRecord
  belongs_to :equipo
  has_many :asistencias, dependent: :destroy
  accepts_nested_attributes_for :asistencias
  scope :done, -> { where(registrado: true) }
  validates :equipo_id, :fecha, :tipoEvento, presence: true
end

so I have a view at 'app/views/eventos/forma_prog.html.erb' which includes a form to get the parameters to define the date range like this:

<% provide(:title, "Entrenamientos") %>
<div class="col-sm-6 col-sm-offset-3">
  <p id="notice"><%= notice %></p>

  <h1>Programación de Entrenamientos</h1>

  <%= form_tag(programa_path) do %>
    <% dias = [] %>
    <%= label_tag(:entrenador, "Trainer:") %>
    <%= select_tag :entrenador, 
       options_from_collection_for_select(@entrenadores, "id", "name"), 
       prompt: "Select the trainer", class: 'form-control' %>
    <b>Days:</b>
    <div class="well">
      <% @dias.each_with_index do |day, index| %>
        <%= label_tag day, day, class: "checkbox-inline nopadding"; %>
        <%= check_box_tag 'dias[]', index, checked = false, class: 
         "nopadding" %>  |
      <% end %>
    </div>
    <%= label_tag(:inicio, "Starting Date:") %>
    <%= date_field_tag :inicio, class: 'form-control' %>
    <%= label_tag(:final, "Ending Date:") %>
    <%= date_field_tag :final, class: 'form-control' %>
    <%= submit_tag "Create events", class: "btn btn-default" %>
  <% end %>
</div>

It works fine and returns params:

{"utf8"=>"✓",
 "authenticity_token"=>"10BsOFEsCvO...==",
 "entrenador"=>"2",
 "dias"=>["2", "4"],    # Being Tuesday and Thursday
 "inicio"=>"2017-06-28",
 "final"=>"2017-06-30",
 "commit"=>"Create events"}

The controller action that generates the form is: eventos#forma_prog

# GET /eventos/forma_prog
def forma_prog
  @entrenadores = User.all
  @dias = %w[Dom Lun Mar Mie Jue Vie Sab]
  @evento = Evento.new
end

And the controller action that is supposed to create the events is eventos#programa:

# POST /eventos/programa
def programa
  entrenador = User.find(params[:entrenador])
  inicio = Date.parse(params[:inicio])
  final = Date.parse(params[:final])
  dias = params[:dias].map! {|ele| ele.to_i }
  @tipoEvento = "Entrenamiento"

  entrenador.equipos.each do |equipo|
    for @fecha in (inicio..final) do
      if dias.include?(@fecha.wday)
        @equipo_id = equipo.id
        @evento = Evento.new(evento_params)
        if !@evento.save
          flash[:error] = "No ha sido posible crear los eventos."
          redirect_to root_path
        end
      end
    end
  end
end

When I click the submit button I get an error saying param is missing or the value is empty: evento and the app console points to the eventos#evento_params:

# Never trust big bad internet, always use strong params
def evento_params
  params.require(:evento).permit(:fecha, :tipoEvento, :equipo_id, :comment, :registrado, :asistencias_attributes => [:evento_id, :player_id, :tipo, :comment])
end

I can see that the params.require(:evento) part is the problem and I guess it has something to do with the 'form_tag' I chose instead a 'form_for @evento' But I did this way because I think the form is not fully related with the @evento object for the model, please help me here...

Answer 1

You are correct, the first problem is that form_tag doesn't group all evento values in one key, as you are expecting.

This can be solved using form_for but, if you would like to keep form_tag , just rename the inputs with evento[attribute] .

Where attribute is the name of the parameter/field (eg evento[fecha] for your input fecha ).

After fixing the above, the error you mention will go away, but will another one will be raised because none of the attributes needed to create an Evento is sent in your form .

So, the second problem is that the form is not sending all the parameters; you can see those needed parameters in evento_params method:

def evento_params
  params.require(:evento).permit(:fecha, :tipoEvento, :equipo_id, :comment, :registrado, :asistencias_attributes => [:evento_id, :player_id, :tipo, :comment])
end

This means that evento_params is expecting a Parameters hash with this structure:

{
  "utf8"=>"✓",
  "authenticity_token"=>"...",
  "evento"=>{
    "fecha"=>"...",
    "tipoEvento"=>"...",
    "equipo_id"=>"...",
    "comment"=>"...",
    "registrado"=>"...",
    "asistencias_attributes"=>[
      {
        evento_id=>"...",
        player_id=>"...",
        tipo=>"...",
        comment=> "..."
      }
    ],
  "commit"=>"Create events"
}

To fix this, you either need to send all those missing parameters, or adjust evento_params method to use only the ones sent by the form .