Excel VBA获取范围内非空行的计数

Question

I know this has been asked at least a dozen times, but of all those questions the solutions seemed to be tailored or simply created an error in my code. For some reason I get an error when I try and reference a range from a different worksheet. Below is my code. I have two worksheets (tabs). One has a button to launch my code MENU , the other is the data I am trying to read and write to RAW . All I am trying to do is find out how many rows of data the sheet has so I can loop through the rows and make changes. For some reason I can't wrap my head around it or something.

Private Sub CommandButton21_Click()
  Dim wbCurrent As Workbook
  Dim wsCurrent As Worksheet

  Set wbCurrent = ThisWorkbook
  Set wsCurrent = wbCurrent.Worksheets("RAW")

  Dim i As Long
  Dim siteCol As Long

  siteCol = Range("I" & Rows.Count).End(xlUp).Row
  For i = 1 To siteCol
    wsCurrent.Range("I" & i) = "MARKED"
  Next i
  Range("I1") = siteCol
End Sub

Answer 1

1- Always use Long for your variables, not Integer unless you have a specific reason. The maximum value of an Integer is 32767 , which might be not enough to hold your count of rows.

2- Dont get the number of rows with COUNTA , this has many drawbacks. use this instead:

siteCol = wsCurrent.Range("I" & wsCurrent.Rows.count).End(xlUp).Row

This finds the Row number of the last occupied cell in wsCurrent , assuming that wsCurrent is at the top of the document (it starts on Row 1). Please note that if wsCurrent is completely empty, this will find the row number of the first occupied cell above wsCurrent , or the first row of the document.

3- When you want to assign a whole range to the same value, you can do it at once, which is much faster and simpler, like this (no loop needed):

wsCurrent.Range("I1:I" & siteCol) = "MARKED"

4- No need to Activate a worksheet to work with it. Drop the statement wsCurrent.Activate and try to always work with qualified ranges.