如何修复存储数据的功能？

Question

My function runs URLcrazy and I figured out it is not storing the output into any variables and I cannot figure it out. The tmp variable shown is not storing the output into that list. How I can fix this to store the data executed.

def run_urlcrazy():
   tmp = []
    for domain in grab_domains():
      np = os.system("urlcrazy " + domain)
      tmp.append(np)
   return tmp

I am trying to get the output of URLcrazy ran against all the domains in the loop and be able to slice the ouptut. I think the way URLcrazy is outputting data I am unable to format the data in another function. Which I need to be able to do in order to store information in a database.

Answer 1

os.system does not return the output of the command executed, only the exit code (signals success or error).

I believe you want subprocess.Popen :

import subprocess

def run_urlcrazy():
    tmp = []
    for domain in grab_domains():
        proc = subprocess.Popen(["urlcrazy", domain], stdout=subprocess.PIPE)
        (out, err) = proc.communicate()
        tmp.append(out)
   return tmp

Alternatively, you can use subprocess.check_output if you just want the output and are not interested in checking for errors:

out = subprocess.check_output(['urlcrazy', domain])