在ASP MVC中创建线程安全的静态字典

Question

I am working on an ASP.NET MVC application which includes a static Dictionary. This is problematic because the Dictionary class is not thread-safe, which may cause trouble when it is accessed by concurrent web requests. I am considering wrapping the dictionary like this:

public class DataDictionary
{
    private object Lock = new object();
    private int NextId = 0;
    private Dictionary<int, Data> DataLog = new Dictionary<int, Data> {};

    public int Add(Data data)
    {
        lock (Lock)
        {
            var id = NextId++;
            DataLog.Add(id, data);
            return id;
        }
    }

    public Data GetData (int id)
    {
        lock (Lock)
        {
            return DataLog[id];
        }
    }

    public void Remove(int id)
    {
        lock (Lock)
        {
            DataLog.Remove(id);
        }
    }
}

Will this allow safe access to the Dictionary by concurrent web requests? If not, what can I do to facilitate similar behavior safely?

Answer 1

What about a ConcurrentDictionary, there's documentation on it here .

The first line of this documentation states:

Represents a thread-safe collection of key/value pairs that can be accessed by multiple threads concurrently.