双指针循环中的分段错误

Question

Here is my code

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main ()
{
  char str[] ="a,b,c,d,e";

  struct stri {
          int i;
          char *data;
  };
  struct stri **pstri = NULL;
  char *pch;
  pch = strtok (str,",");
  int i = 0;
  while (pch != NULL)
  {
    printf("before: %s\n", pch);
    pstri = realloc(pstri, (i + 1) * sizeof(struct stri*));
    struct stri *s = malloc(sizeof(struct stri));
    s->i = i;
    s->data = strdup(pch);
    pstri[i] = s;
    i++;
    pch = strtok (NULL, ",");
  }
  //update
  // should I realloc here too?
  pstri[i] = NULL;
  //update


  int j = i;
  for(i = 0; i<j; i++) {
    printf("after: %d=>%s\n", pstri[i]->i, pstri[i]->data);
  }

  struct stri *k = NULL;
  while(k = *pstri++) {
    printf("after2: %d=>%s\n", k->i, k->data);
  }

  return 0;
}

output is

before: a
before: b
before: c
before: d
before: e
after: 0=>a
after: 1=>b
after: 2=>c
after: 3=>d
after: 4=>e
after2: 0=>a
after2: 1=>b
after2: 2=>c
after2: 3=>d
after2: 4=>e
Segmentation fault

Answer 1

While loop exit when pch = strtok (NULL, ",") makes pch NULL but we haven't set NULL at i = 5 for pstri. This same segmentation fault can happen if you set j = 6 instead of j = i because i is protecting this after: loop.