Node.js和快速重定向到https不适用于主页

Question

I'm using express to serve static files on my vps. I created two servers http and https like so:

var httpServer = http.createServer(app);
httpServer.listen(httpPort);

var httpsServer = https.createServer(credentials, app);
httpsServer.listen(httpsPort);

By using a middlewear like below:

app.use(function (req, res, next) { 
    !req.secure 
        ? res.redirect(301, path.join('https://', req.get('Host'), req.url)) 
        : next();
});

Most of my requests are well redirected to https. However, when loading my website with only the domain without ssl ( http://example.com ) and without any child routes (like http://example.com/contact ), this is not redirecting to https.

Edit

I serve static files (an angular 4 app compiled for production):

app.use(express.static(path.join(__dirname, distFolder)));

And I have as route what follows:

app.get('*', (req, res) ={ 
    res.sendFile(path.join(__dirname, distFolder, 'index.html'));
});

---

Can you help me to find out what I missed ? I didn't find answer for this exact issue.

Thank you.

Answer 1

We can also use node-rest-client for redirecting properly to any URL.

You can install it by npm install node-rest-client

Answer 2

path.join is meant for joining together path elements, and should not be used to construct URLs. In your example the redirect url will be missing one of the leading slashes.

> path.join('https://', 'example.com', '/hello/world')
'https:/example.com/hello/world'

Instead you can use url.format , which will construct a proper url.

> url.format({ protocol: 'https:', host: 'example.com', pathname: '/hello/world' })
'https://example.com/hello/world'

Your code would look something like this:

app.use(function (req, res, next) {
  if (req.secure) return next()

  const target = url.format({
    protocol: 'https:',
    host: req.get('Host'),
    pathname: req.url
  })

  res.redirect(301, target)
})

Answer 3

I finally found out what was the issue: I was serving the public folder before the security test...

So here are the steps now:

// Step 1: Test all incoming requests (from http and https servers).

app.use(function (req, res, next) {
    if (req.secure) 
        return next();

    var target = url.format({ // Thanks Linus for the advice!
        protocol: 'https:',
        host: req.hostname,
        pathname: req.url
    });

    res.redirect(301, target);
});

// Step 2: Serve static files.

app.use(express.static(path.join(__dirname, 'your/dist/folder')));

// Step 3: Build routes (in my case with * because of the SPA).

app.get('*', function (req, res) {
    res.sendFile(path.join(__dirname, 'your/dist/folder', 'index.html'));
});

Now it is working perfectly!

Answer 4

我建议您尝试在Web服务器层而不是应用程序层上解决此问题，并通过80和443接收安全请求和非安全请求/流量。