jQuery siblings.data（）没有返回正确的值

Question

I have a Html like :

<div class="ajouterContainer" id="ajouterContainer1">
    <div class="ajouter ajoutersaved" id="ajouter1" data-no="1" style='background-image: url(..."); background-color: rgb(255, 0, 0);' >
        <div class="pieceModifierContainer"></div>
        <a onclick="return false;" href="#">
            <label>INCLUSION</label>
        </a>
        <span class="pieceFileName">INC-00001_41-H.png</span>
    </div>
    <span class="submenuOpener opened" id="smo1" style="background-color: rgb(255, 0, 0);">▼<input type="hidden"></span>
</div>

I try to get the data-no attribute of the ajouter1 on click event of ajouterContainer div by :

$(".ajouterContainer").on("click", function(event) {
    var itemID = $(event.target).attr('id');
    var itemNumber = itemID.substring(itemID.length - 1);
    var idToFind = "#smo" + itemNumber;
    var openerItem = $(event.target).find(idToFind);
    if (!openerItem.length) {
        $(event.target).css("background-color", "red");
        return;
    }
    //the data-no attribute is 3 by default. I change it using jQuery to 1.
    var dataNo = openerItem.siblings().data("no"); //returns 3
    $(openerItem).prev().attr("data-no"); // returns 1 (the correct value).

});

What is wrong with openerItem.siblings().data("no"); ? Before changing it by code, it works.

Answer 1

You should filter your siblings using $(openerItem).siblings('[data-no]').data('no')

EDIT:

The problem isn't the siblings() method; it's because you're using event.target that takes the child element which is actually clicked and not the ajouterContainer1 . I've replaced it with this which should work for you. I hope this helps:

 $(".ajouterContainer").on("click", function(event) { var itemID = this.id; var itemNumber = itemID.substring(itemID.length - 1); var idToFind = "#smo" + itemNumber; var openerItem = $(this).find(idToFind); if (!openerItem.length) { $(event.target).css("background-color", "red"); return; } //the data-no attribute is 3 by default. I change it using jQuery to 1. var dataNo = openerItem.siblings().data("no"); //returns 3 console.log(dataNo); }); 

 <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script> <div class="ajouterContainer" id="ajouterContainer1"> <div class="ajouter ajoutersaved" id="ajouter1" data-no="1" style='background-image: url(..."); background-color: rgb(255, 0, 0);' > <div class="pieceModifierContainer"></div> <a onclick="return false;" href="#"> <label>INCLUSION</label> </a> <span class="pieceFileName">INC-00001_41-H.png</span> </div> <span class="submenuOpener opened" id="smo1" style="background-color: rgb(255, 0, 0);">▼<input type="hidden"></span> </div>