C＃从文本文件写入listView

Question

I created windows application in C# that writes from text file to listView. I first executed commands in cmd to list system and user apps from the phone and I put cmd output to text file. Now I want to add content of text file to listView: in first column apps from /system/app should be listed, in second apps from /system/priv-app and in third apps from /data/app! When I press the button to execute function I get error:System.ArgumentException: Cannot add or insert the item '' in more than one place. You must first remove it from its current location or clone it.

Process  process;
ProcessStartInfo startInfo;
private void Form1_Load(object sender, EventArgs e)
{
    process = new Process();
    startInfo = new ProcessStartInfo();
    startInfo.FileName = "cmd.exe";
    startInfo.ErrorDialog = false;
    startInfo.UseShellExecute = false;
    startInfo.RedirectStandardError = true;
    startInfo.RedirectStandardInput = true;
    startInfo.RedirectStandardOutput = true;
    startInfo.WindowStyle = ProcessWindowStyle.Hidden;
    startInfo.Arguments = "/C adb devices&adb shell pm list packages -f";
}

private void Redirect_ADB_Output()
{
    using (Process process = Process.Start(startInfo))
    {
        using (StreamReader reader = process.StandardOutput)
        {
            string result = reader.ReadToEnd();
            File.WriteAllText("ADB.txt", result);
        }
    }   
}

private void WriteToListView()
{
    ListViewItem lvItem = new ListViewItem();
    var lines = File.ReadLines("ADB.txt");
    foreach (var line in lines)
        {
            ListViewItem lvItem = new ListViewItem();
            if (line != string.Empty)
            {
                var newLine = line.Remove(0, 8);

                if (line.Contains("package:/system/app"))
                {
                    ApkList.Items.Add(newLine);
                }
                if (line.Contains("package:/system/priv-app"))
                {
                    lvItem.SubItems.Add(newLine);
                }
                if (line.Contains("package:/data/app"))
                {
                    lvItem.SubItems.Add(newLine);
                }
            }
            ApkList.Items.Add(lvItem);
        }
    File.WriteAllText("ADB.txt", string.Empty);
}

private void btn_PullApkFromPhone_Click(object sender, EventArgs e)
{
    startInfo.Arguments = "/C adb devices&adb shell pm list packages -f";
    Redirect_ADB_Output();

    WriteToListView();
}

Answer 1

I think it may be because you are modifying an element while looping over it.

Try creating a new object and adding that to the collections (also, as another user pointed out, try moving the ListView into the foreach loop):

foreach (var line in lines)
{
    ListViewItem lvItem = new ListViewItem();

    var newLine = line.Remove(0, 8);

    if (line.StartsWith("package:/system/app"))
    {
        ApkList.Items.Add(newLine);
    }
    if (line.StartsWith("package:/system/priv-app"))
    {
        lvItem.SubItems.Add(newLine);
    }
    if (line.StartsWith("package:/data/app"))
    {
        lvItem.SubItems.Add(newLine);
    }
    ApkList.Items.Add(lvItem);
}

Answer 2

I would suggest first adding "columns", this helps.

ListViewItem lvItem = new ListViewItem();
ApkList.View = View.Details;
ApkList.Columns.Add("Col1");
ApkList.Columns.Add("Col2");
ApkList.Columns.Add("Col3");

THEN You need to do this for the foreach.

foreach (var line in lines)
{
  if (line != string.Empty)
  {
      var newLine = line.Remove(0, 8);

      if (line.Contains("package:/system/app"))
      {
          lvItem.Text = newLine;
      }
      if (line.Contains("package:/system/priv-app"))
      {
          lvItem.SubItems.Add(newLine);
      }
      if (line.Contains("package:/data/app"))
      {
          lvItem.SubItems.Add(newLine);
      }
   }            
}

ApkList.Items.Add(lvItem);

You'll then need a final loop around the above, for, foreach, while to populate your entire list.