使用django在芹菜中传递User对象

Question

I'm currently editing the save method in one of my models, so that I can save who changed an object or created a new one.

Currently, its working fine when its ran in the main thread, but the save method is also used in different tasks through Celery. And when the save method is ran in a task get user returns None . To get a user i'm currently using django-curser since this model is being used in different apps inside my Django project.

Is there a way to send the current user to celery? I've been told to use a context manager or a wrapper but im not sure how.

My save method is:

    def save(self, *args, **kwargs):
        from models import Log
        log_entry = Log()
        log_entry.object_id = self.id
        log_entry.object_repr = self
        user = CuserMiddleware.get_user()
        log_entry.user = user
        log_entry.content_type_id = ContentType.objects.get_for_model(self).id
        log_entry.save()

Thanks.

Answer 1

Solution with decorator:

I think you can use this decorator to add user in celery task

from functools import wraps


def append_user(func):
    @wraps(func)
    def __wrapper__(*args, **kwargs):
        user_login = kwargs.pop('user_login')
        CuserMiddleware.set_user(user_login)
        return func(*args, **kwargs)
    return __wrapper__

And apply it to task this way

@task
@append_user
def celery_job():
    pass

Also for my celery task I use this decorator (to turn off all async jobs in settings)

def async_task(func):
    from django.conf import settings
    ALL_TASKS_IS_ASYNC = getattr(settings, 'ALL_TASKS_IS_ASYNC', True)

    @wraps(func)
    def __wrapper__(*args, **kwargs):
        async = kwargs.pop('async', ALL_TASKS_IS_ASYNC)
        if async:
            return func.delay(*args, **kwargs)
        else:
            return func(*args, **kwargs)
    return __wrapper__

And celery_job = async_task(celery_job) in __init__.py file

You can use the same idea to append user_login to all tasks

def async_task(func):
    from django.conf import settings
    ALL_TASKS_IS_ASYNC = getattr(settings, 'ALL_TASKS_IS_ASYNC', True)

    @wraps(func)
    def __wrapper__(*args, **kwargs):
        kwargs['user_login'] = CuserMiddleware.get_user().username
        async = kwargs.pop('async', ALL_TASKS_IS_ASYNC)
        if async:
            return func.delay(*args, **kwargs)
        else:
            return func(*args, **kwargs)
    return __wrapper__

Edit:

I think this decorator may optimize refactoring:

def task_with_user_info(func):
    @wraps(func)
    def __wrapper__(*args, **kwargs):
        user = CuserMiddleware.get_user()
        kwargs['user_login'] = user.username
        return func(*args, **kwargs)
    if getattr(func, 'delay', None):
        __wrapper__.delay = task_with_user_info(func.delay)
    return __wrapper__


@task_with_user_info
@task
@append_user
def celery_job():
    pass

After this changes you should able to use celery_job as usual.