为什么我的getColor函数总是返回false？

Question

I have a function that gets user input and its supposed to validate the user input from a list of options. The last part of the function, where I cycle through results and return true, if there's a true boolean value in results doesn't seem to be working properly. It keeps returning false.

    function getColor(){
        //gets user color and makes all characters lower case;
        let color=prompt("Pick a color, your options are white, yellow, brown, black, tan, red, orange").toLowerCase();

        //stores acceptable colors
        let acceptableColors=["white","yellow", "brown", "black","tan","red","orange"];

        function validate(){
            let results=[];
            for(let i=0; i<acceptableColors.length; i++){//loops through and stores a true value in results if user color is in list of acceptableColors
                    if(color===acceptableColors[i]){
                        results.push(true);
                    }
                    else{
                        results.push(false);
                    }

            }

            results.forEach(function(item){//loops through results to search for true value and returns true, if it finds one
                if(item===true){
                    return true
                }
            });
             return false;//returns false if user entered invalid color

        }
        return validate();

    }

Answer 1

It keeps returning false.

Return false inside forEach will not return from getColor and your return false is unconditional

Make it

    return results.some(function(item){
       return item;
    });

Answer 2

Here is a simple way:

function validate(){
        let results=[];
        for(let i=0; i<acceptableColors.length; i++){//loops through and stores a true value in results if user color is in list of acceptableColors
                if(color===acceptableColors[i]){
                    return true;
                }    
        }
        return false;//returns false if user entered invalid color

    }

Answer 3

I would prefer doing this way

 function validate() { return acceptableColors.indexOf(color) !== -1; } 

Answer 4

Your whole function can be simplified. There's no need to push booleans in an array, and then check that array for truthy values. Just use includes to check if the color array includes the user's prompted color.

function getColor() {
  let color = prompt("Pick a color, your options are white, yellow, brown, black, tan, red, orange").toLowerCase();
  let acceptableColors = ["white", "yellow", "brown", "black", "tan", "red", "orange"];
  return acceptableColors.includes(color);
}

getColor();