如果今天的日期在12月1日至1月5日之间

Question

Trying to write an IF statement to show Christmas opening hours, using the formula that if todays date is between 1st December and 5th January, otherwise show the normal times. But all I'm getting is the normal times.

$xmasStart = date('m-d', strtotime('11-01'));
$xmasEnd = date('m-d', strtotime('01-05'));
if((date('m-d') > $xmasStart) && (date('m-d') < $xmasEnd)) {
    echo 'Christmas Opening Hours';
} else {
    echo '<p class="marginbottom0">Monday to Friday: 8am - 6pm<br><small>Saturday &amp; Sunday: Appointment only</small></p>';
}

Answer 1

Don't use strings to do date math. Use DateTime() which is clearer and easier to understand.

DateTime() objects are comparable so you don't need to convert them to strings to do comparisons. Additionally, it is timezone and daylight savings time aware (which doesn't come into play here but may at other times you works with dates).

<?php

$xmasStart = new DateTime('11/1 00:00:00');
$xmasEnd = new DateTime('1/5 23:59:59');
$now = new DateTime();
if($now >= $xmasStart && $now < $xmasEnd) {
    echo 'Christmas Opening Hours';
} else {
    echo '<p class="marginbottom0">Monday to Friday: 8am - 6pm<br><small>Saturday &amp; Sunday: Appointment only</small></p>';
}

Additionally, I added the times to each day as DateTime, and strtottime() will use the current time and not the beginning or ending of each day so on the last day of the Xmas hours you will not show the right hours. (You can also change the last day to be 1/6 00:00:00 ).

Demo

Answer 2

strtotime doesn't understand your short time definition, try to use complete date in Ymd format ( 2017-12-01 and 2018-01-05 respectively). Please also notice that your comparison doesn't include edge dates so you may want to use <= and >= instead.

$xmasStart = date('Y-m-d', strtotime('2017-12-01'));
$xmasEnd = date('Y-m-d', strtotime('2018-01-05'));
$now = date('Y-m-d');
if(($now >= $xmasStart) && ($now <= $xmasEnd)) {
    echo 'Christmas Opening Hours';
} else {
    echo '<p class="marginbottom0">Monday to Friday: 8am - 6pm<br><small>Saturday &amp; Sunday: Appointment only</small></p>';
}