在DOM元素上每个Jquery - 推入数组错误

Question

I try to use each() function on my DOM to get field dynamically added. But I hava a probleme with this code :

  var nouvelle_entree=new Object();
    $('div[name="declaration-ligne-entree"]').each(function () {
    nouvelle_entree.name=$(this).children('input[name="system-input-name"]').val();
    nouvelle_entree.values=$(this).children('input[name="system-input-valeur"]').val().split(",");
    console.log(nouvelle_entree);
    mockSystem.input.push(nouvelle_entree);
    });
    console.log(mockSystem.input);

The push function always push the last child and not the other but on my console log in have the good values.

log 1 : {name: "a", values: Array(1)}

log 2 : {name: "b", values: Array(1)}

log 3: [

{name: "b", values: Array(1)}

{name: "b", values: Array(1)}

]

Why ?

Answer 1

Why ?

Since in every iteration you're overwriting the same object nouvelle_entree .

You need to define the object nouvelle_entree in every iteration not just the first time, else the variable will always contains the informations of the last iteration, eg :

$('div[name="declaration-ligne-entree"]').each(function() {
  var nouvelle_entree = {};

  nouvelle_entree.name = $(this).children('input[name="system-input-name"]').val();
  nouvelle_entree.values = $(this).children('input[name="system-input-valeur"]').val().split(",");

  mockSystem.input.push(nouvelle_entree);
});

console.log(mockSystem.input);

Answer 2

By declaring the object nouvelle_entree outside the function you are overwriting the same object again and again which results only the last object to be pushed into the array.

Create the object in each of the iteration.

$('div[name="declaration-ligne-entree"]').each(function () {
  var nouvelle_entree = {};
  nouvelle_entree.name=$(this).children('input[name="system-input-name"]').val();
  nouvelle_entree.values=$(this).children('input[name="system-input-valeur"]').val().split(",");
  console.log(nouvelle_entree);
  mockSystem.input.push(nouvelle_entree);
});
console.log(mockSystem.input);