使用Excel VBA打开工作簿，从certian单元格复制值，保存新表单，然后关闭打开的工作簿

Question

I have a Workbook that is being used to track project information. I have been updating the workbook functionality and macros, but currently do not have means of transferring all of the user entered information to the updated workbook. I am creating an "IMPORT" button that will allow the user to select an older version of the workbook, open that workbook (wbout), copy over the values into the new workbook (wbin), save the new workbook, and close the old one without saving it.

At this point I am having troubles with the Workbooks.Open command. The line that has the command opens the workbook, then I get a

Run Time Error '91': Object Variable or With Block variable not set.

Can someone please advise as to what I am doing wrong? Thanks

Private Sub ImportPrj1_Click()
Dim rngin As Range
Dim rngout As Range
Dim wsin As Worksheet
Dim wsout As Worksheet
Dim wbin As Workbook
Dim wbout As Workbook
Dim namein As String
Dim folderin As Variant
Dim msg As String

Set wbin = ActiveWorkbook

folderin = Application.GetOpenFilename("Excel-files,*.xlsm", 1, "Select Older Version to transfer information from.", , False)
If folderin = False Then Exit Sub

Application.ScreenUpdating = False

wbout = Workbooks.Open(folderin)  ' <--- Line executes but returns error
Set wsin = wbin.Worksheet("P3 PayOuts")
Set wsout = wbout.Worksheets("P3 PayOuts")
wsin.Range("H4").Value = wsout.Range("H4").Value
wsin.Range("C9:V10").Value = wsout.Range("C9:V10").Value
wsin.Range("K3:K5").Value = wsout.Range("K3:K5").Value
wsin.Range("L3:L5").Value = wsout.Range("L3:L5").Value

' Create File name, save new tracker, close old tracker, make summary active,screen updates = true
namein = InputBox("Enter 1-2 word project identifier to be used in the File Name", "File Name")
namein = "Project Tracker V1.2" & namein
msg = "Project Tracker with imported data will be saved in the same folder as the old version"
msg = msg & vbNewLine & vbNewLine & "File Name: " & namein & ".xlsm"
MsgBox (msg)

Application.DisplayAlerts = False
Application.EnableEvents = False

folderin = Application.wbout.Path
namein = folderin & "\" & namein
NewBook.SaveAs Filename:=namein, FileFormat:=52 ' xlOpenXMLWorkbookMacroEnabled

Workbooks(wbout).Close (False)

With Application
    .DisplayAlerts = True
    .EnableEvents = True
    .ScreenUpdating = True
End With

wbin.Worksheets("Summary").Activate

End Sub

Answer 1

You're getting error 91 because you're assigning an object reference without the Set keyword, here:

wbout = Workbooks.Open(folderin)

But once that is fixed, you're getting error 438 because you're referring to a member that isn't defined on the Excel.Workbook interface:

Set wsin = wbin.Worksheet("P3 PayOuts")

That's Worksheets , not Worksheet .

Both of these bugs (and possibly many more - you have unused variables in there, and then I expect NewBook to blow up as well) could have been avoided by inspecting with Rubberduck , an open-source VBIDE add-in project I manage.

Answer 2

Try entering this line into the code above "Wbout = Workbooks.Open(folderin)" line:

Tmp = MsgBox(folderin,vbokonly,"folderin:")

If the result is just a filename (Eg not a full path), try the following amendment (you can then delete the above):

Set WBout = Workbooks.Open(WBin.Path & "\" & folderin)

I also typically use the Sheets collection instead of the Worksheets...not sure if that will change anything, but I have had issues with Worksheets in the past.