如果用户未使用构造函数进行身份验证，则无法重定向到登录页面

Question

I have an Admin controller which handles the user login and other admin functionality like managing a basic cms. In the constructor I check if the users session present which is set once they login. If not and they try to access a restricted page, they should be redirected. If I redirect to another page then when going to the login page I get redirected right away as obviously that check is done in the constructor, but as soon as I try to redirect to the login page I get an error:

This page isn't working localhost redirected you too many times. Try clearing your cookies. ERR_TOO_MANY_REDIRECTS

class Admin extends Controller {

    public function __construct()

    {

        if(!isLoggedIn()) {

            redirect('admin/login');
        }

        $this->AuthModel = $this->model('Auth');

    }

isLoggedIn is a function:

function isLoggedIn() {

    if(isset($_SESSION['user_id']) && isset($_SESSION['browser']) && $_SESSION['browser'] == $_SERVER['HTTP_USER_AGENT']) {

        return true;

    } else {

        return false;
    }
}

Login method:

public function login()
{
if($_SERVER['REQUEST_METHOD'] == 'POST') {

    $email = filter_var($_POST['email'], FILTER_SANITIZE_EMAIL);
    $password = trim($_POST['password']);

    $data = [

    'email' => $email,
    'password' => $password,
    'email_error' => '',
    'pass_error' => '',
    'no_user' => '',
    'pass_wrong' => ''

    ];

    if(!filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) {

        $data['email_error'] = 'Invalid email address <br />';
    }

    if(empty(trim($_POST['password']))) {

        $data['pass_error'] = 'Password required';
    }

    if(!empty(trim($_POST['email'])) && !$this->AuthModel->getUserByEmail($email)) {

        $data['no_user'] = 'Email does not exist';
    }


    if(!empty($data['email_error']) || !empty($data['pass_error']) || !empty($data['no_user'])) {

        $this->view('admin/login', $data);

    } else {

        $loggedInUser = $this->AuthModel->login($email, $password);

        if($loggedInUser) {

            $this->CreateUserSession($loggedInUser);


        } else {

            $data['pass_wrong'] = 'Incorrect login details';
            $this->view('admin/login', $data);
        }
    }

} else {

    $data = [

        'email' => '',
        'password' => '',
        'email_error' => '',
        'pass_error' => '',
        'no_user' =>'',
        'pass_wrong' => ''
    ];

    $this->view('admin/login', $data);
  }
}

Answer 1

You are using same controller for login and other functionalities. Every time it checks for authentication and it gets no. And it loops over again. try to implement your login functionalities in a separate Controller .