OnTouch在播放器类中不起作用

Question

I am creating a game and would like to read the player input for the character in the characters class. I don't know if this is good practice for game development however it seems like the logical thing to do.

I have the following code within my Player class (relevant code included) however my suspicion is that it isn't working as it isn't the primary view class or something? All help is appreciated. Player

public class Player implements View.OnTouchListener{

    private static Player instance = null;

    int x, y;
    boolean moveRight = false;
    Bitmap sprite;

    public Player (Context context){

        sprite = BitmapFactory.decodeResource(context.getResources(), R.drawable.test_sprite);
        x = 300;
        y = 0;
    }

    public void Update(){
        if (moveRight){
            x += 3;
        } else {
            x -= 3;
        }
    }

    public static Player getInstance(Context context) {
        if (instance == null){
            instance = new Player(context);
        }
        return instance;
    }

    @Override
    public boolean onTouch(View view, MotionEvent motionEvent) {
        float x = motionEvent.getX(), y = motionEvent.getY();
        switch (motionEvent.getAction() & motionEvent.getActionMasked()){
            case MotionEvent.ACTION_DOWN:
                moveRight = true;
                break;
            case MotionEvent.ACTION_UP:
                moveRight = false;
                break;
        }
        return true;
    }
}

GameView

public class GameView extends SurfaceView implements Runnable {

    private boolean running = true;

    SurfaceHolder surfaceHolder = getHolder();

    SimpleTurret simpleTurret;
    Player player;

    private Thread thread = new Thread(this);

    public GameView (Context context){
        super(context);

        simpleTurret = SimpleTurret.getInstance(context);
        player = Player.getInstance(context);

        thread.start();
    }

    @Override
    public void run() {
        while (running){
            DrawCanvas();
            Control();
        }
    }

    public void DrawCanvas(){
        Canvas canvas = surfaceHolder.lockCanvas();
        if (surfaceHolder.getSurface().isValid()){
            canvas.drawColor(Color.RED);
            canvas.drawBitmap(simpleTurret.getSprite(), simpleTurret.getX(), simpleTurret.getY(), null);
            canvas.drawBitmap(player.getSprite(), player.getX(), player.getY(), null);
            surfaceHolder.unlockCanvasAndPost(canvas);
        }
    }

    public void Control(){
        try{
            thread.sleep(17);
        } catch(InterruptedException e){
            e.printStackTrace();
        }
    }
}

Answer 1

public class GameView extends SurfaceView implements Runnable, OnTouchListener {

  public GameView(Context context) {
    super(context);
    this.setOnTouchListener(this);
  }

  @Override
  public boolean onTouch(View view, MotionEvent motionEvent) {
    return false;
  } ...

this.setOnTouchListener(this); line puts the OnTouchListener on the GameView class which extends the SurfaceView . So now anytime there is a touch on your SurfaceView the onTouch method would be called

Answer 2

You can use ImageView instead a Bitmap and set your implementation of View.OnTouchListener with the method setOnTouchListener :

ImageView sprite;

public Player (Context context){
    sprite = new ImageView(context);
    sprite.setBackgroundResource(R.drawable.monkey);
    sprite.setOnTouchListener(this);
    x = 300;
    y = 0;
}