从SQL Server 2012中的SP动态创建视图

Question

sql server 2012

i have created a SP to create view dynamically with Parameter i supplied.

below is the code

i am not sure why i am getting the below error.

Msg 102, Level 15, State 1, Procedure uspCreateView, Line 10 Incorrect syntax near '@VIEWNM'.

Code:

CREATE PROCEDURE uspCreateView
@VIEWNM VARCHAR(50),
@COMP INT,
@TODT DATE = 9999-12-31


    AS
    EXEC ('

    CREATE VIEW +'@VIEWNM'
    AS
(
SELECT
COL1,
COL2,
COL3,   
DATE,   
SKU,    
CASE WHEN IsRowCurrent = 1 THEN '@TODT' ELSE dateadd(MILLISECOND, -1000 - datepart(MILLISECOND, FMDT), FMDT) END AS TODT,

FROM MYTABLE mt


OUTER APPLY (   SELECT  MAX(DATEADD(second, -1, FMDT)) TO_DATE 
                        FROM    MYTABLE mt2 
                        WHERE   mt2.COL1 = mt.COL1 
                                AND mt2.COL2 = mt.COL2 
                                AND mt2.FMDT > mt.FMDT
                                AND mt.COL3 = '@COMPID'  ) oa
  WHERE mt.COL3 = '@COMPID'
  )  

please help me to fix the below error. Thanks

Answer 1

It should be
CREATE VIEW ' + @VIEWNM + ' AS...

Answer 2

I am not sure, why you want to create views dynamically, ideally views should be created before hand only, and you will be required to fetch the data depending on the condition.

Still if you want to proceed, you should do it proper way to avoid any issues. I can see there are issues with your implementation. Ideally you should make it parameterized, like following sample query to avoid any SQL injection.

There are issues with your provided code also, I tried to fix some of these.

CREATE PROCEDURE uspCreateView 
    (
      @VIEWNM      VARCHAR(50), 
      @COMP        INT, 
      @TODT        DATE = '9999-12-31' 
      )
    AS
    BEGIN
     DECLARE @Query NVARCHAR(MAX) 
     DECLARE @ParmDefinition nvarchar(MAX);  
    SET @Query = N'CREATE VIEW @VIEWNM_I     AS ( SELECT COL1, COL2, COL3, DATE, SKU, 
        CASE WHEN IsRowCurrent = 1 THEN @TODT_I ELSE 
        dateadd(MILLISECOND, -1000 - datepart(MILLISECOND, FMDT)
        , FMDT) END AS TODT, FROM MYTABLE mt OUTER APPLY (   
        SELECT  MAX(DATEADD(second, -1, FMDT)) TO_DATE                         
        FROM    MYTABLE mt2                         
        WHERE   mt2.COL1 = mt.COL1                                 
        AND mt2.COL2 = mt.COL2                                 
        AND mt2.FMDT > mt.FMDT                                 
        AND mt.COL3 = @COMPID_I  ) oa  
        WHERE mt.COL3 = @COMPID_I)' 
    SET @ParmDefinition = N'@VIEWNM VARCHAR(100),@TODT_I DATETIME,@COMP_I INT';  
    EXECUTE sp_executesql @Query,@ParmDefinition, @VIEWNM_I=@VIEWNM,  @COMP_I=@COMP, @TODT_I=@TODT
    END

Answer 3

Try this

Command(s) completed successfully.

CREATE PROCEDURE uspCreateView
@VIEWNM VARCHAR(50),
@COMP INT,
@TODT DATE = '9999-12-31'


    AS
    EXEC ('

    CREATE VIEW '+@VIEWNM+'
    AS
(
SELECT
COL1,
COL2,
COL3,   
DATE,   
SKU,    
CASE WHEN IsRowCurrent = 1 THEN '+@TODT+' ELSE dateadd(MILLISECOND, -1000 - datepart(MILLISECOND, FMDT), FMDT) END AS TODT,

FROM MYTABLE mt


OUTER APPLY (   SELECT  MAX(DATEADD(second, -1, FMDT)) TO_DATE 
                        FROM    MYTABLE mt2 
                        WHERE   mt2.COL1 = mt.COL1 
                                AND mt2.COL2 = mt.COL2 
                                AND mt2.FMDT > mt.FMDT
                                AND mt.COL3 = '+@COMP+'  ) oa
  WHERE mt.COL3 = '+@COMP+'
  )  ')