运行时检查失败＃2-变量'numberchoices'周围的堆栈已损坏

Question

I am having this terminal error every time I finish the debug program.

What I am doing:

[this program is a simple Lottery Numbers Comparison between user input numbers with the non-repeated random lottery numbers. eg using what if it got 4 right of 6]

but it turns out that the program is not working or at least, be stable.

Here's my code:

#include <iostream>
#include <string>
#include <fstream>
#include <sstream>
#include <time.h>
#include <ctime>
#include <algorithm>
using namespace std;

int main()

{
cout << "[La Loteria Electronica]\n";
cout << "Escoge 6 n" << char(163) << "meros del (1 al 49): \n";
int numberchoices[] = { 0 };

for (int w = 1; w < 7; w++)
{
    cout << "N" << char(163) << "mero #" << w << ": ";
    cin >> numberchoices[w];
} // user numbers



    //lottery numbers
    int i, j, k, nums[51];
    srand((int)time(0));
    for (i = 1; i < 50; i++) nums[i] = i;
    for (i = 1; i < 50; i++)
    {
        j = (rand() % 49) + 1;
        k = nums[i]; nums[i] = nums[j]; nums[j] = k;
    }
    cout << "The lottery numbers are:  ";
    for (i = 1; i < 7; i++) cout << nums[i] << " ";

    if (numberchoices[i] = nums[i])
    {
        cout << "gud\n";
    }

    if (numberchoices == nums)
    {
        cout << "gud 2";
    }
  /**/




cout << "\n\n";
system("pause");

Answer 1

Please ?

int numberchoices[] = { 0 };

for (int w = 1; w < 7; w++)
{
    cout << "N" << char(163) << "mero #" << w << ": ";
    cin >> numberchoices[w];
} // user numbers

You're declaring an array of size 1 and then you use it up to position 6 ?

I am having this terminal error every time I finish the debug program.

I'm surprised that you're not having a terminal error every time you start debug.

The access of numberchoises at positions from 1 to 6 are UB (Undefined Behavior). That is: all can happens.

Solution: try with

int numberchoices[7] = { }; // initialize all elements to zero!

Another point

if (numberchoices == nums)

not sure that you get what do you expect.

Do you want compare the integer pointer corresponding to numberchoices (a int[1] , suggested int[7] ) with the one corresponding to nums (a int[51] ) ?