在Javascript中调用函数时，创建全局变量并生成随机数并更新变量

Question

I am kinda new in this coding environment and trying to challange myself with exercises.

I am trying to create global variable called quoteNumber and generate a random number and update this variable every time when the function is called.

However with the code below, every time I call the function quoteNumber variable stays the same and not updated with new random number.

I can solve this putting all variables inside the function but since I am using those variables in different functions I guess it is better for me to create global variable for it.

What are your suggestions?

 var quotes = [{"quote":"Knowledge speaks, but wisdom listens.","author":"Jimi Hendrix"}]; var quoteNumber = 0 ; var generatedQuote = quotes[quoteNumber].quote; var generatedAuthor = quotes[quoteNumber].author; function quoteGenerator () { quoteNumber = Math.floor(Math.random() * 80) + 1; document.getElementById("text").innerHTML = generatedQuote; document.getElementById("author").innerHTML = generatedAuthor; } function share() { document.getElementById("tweet-quote").attr('href', 'https://twitter.com/intent/tweet?hashtags=quotes&text=' + encodeURIComponent('"' + generatedQuote + '" ' + generatedAuthor)); } 

PS- I have shortened the quotes variation and put here not to create confusion

Answer 1

When calling the function you are properly updating the quoteNumber -variable. However, both generatedQuote and generatedAuthor are still the value you set from the beginning. So, after setting the quoteNumber to a new value, you will have to do

generatedQuote = quotes[quoteNumber].quote;
generatedAuthor = quotes[quoteNumber].author;

To update those variables as well.