开关只工作一次

Question

Even though I have put my OnCheckedChangeListener in both onCreateOptionsMenu and onPrepareOptionsMenu, the switch only works once if I deactivate it from my service. After that, nothing happens if I switch it on again.

In MainActivity:

    @Override
public boolean onCreateOptionsMenu(Menu mMenu) {
    getMenuInflater().inflate(R.menu.menu, mMenu);
    switchlistener(mMenu);
    return true;
}

@Override
public boolean onPrepareOptionsMenu(Menu menu) {
    mMenu = menu;
    switchlistener(mMenu);
    return super.onPrepareOptionsMenu(menu);
}

method:

private void switchlistener(Menu mMenu) {
    MenuItem appBarSwitch = mMenu.findItem(R.id.app_bar_switch);
    appBarSwitch.setActionView(R.layout.switch_item);
    mSwitch = mMenu.findItem(R.id.app_bar_switch).getActionView().findViewById(R.id.action_switch);
    mSwitch.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
        @Override
        public void onCheckedChanged(CompoundButton compoundButton, boolean isChecked) {
            if (isChecked) {
                Toast.makeText(MainActivity.this, "Fired up!", Toast.LENGTH_SHORT).show();
                Intent intent = new Intent(getApplicationContext(), BroadcastReceiverService.class);
                startService(intent);
            } else {
                Intent intent = new Intent(getApplicationContext(), BroadcastReceiverService.class);
                stopService(intent);
            }
        }
    });
}

In Service class:

    @Override
public int onStartCommand(Intent intent, int flags, int startId) {
    if (intent.getAction() != null && intent.getAction().equals("SWITCH OFF")) {
        stopForeground(true);
        stopSelf();

        Menu menu = MainActivity.getThis().getMenu();
        MenuItem appBarSwitch = menu.findItem(R.id.app_bar_switch);
        appBarSwitch.setActionView(R.layout.switch_item);
        appBarSwitch.setChecked(false);

    } else {
        Toast.makeText(this, "Service Started", Toast.LENGTH_SHORT).show();
    }
    return START_NOT_STICKY;

}

Thanks for any help!

Answer 1

For the record, the answer was to put my switchListener method inside the OnStartCommand. That way, it gets called again.

@Override
public int onStartCommand(Intent intent, int flags, int startId) {
    if (intent.getAction() != null && intent.getAction().equals("SWITCH OFF")) {
        stopForeground(true);
        stopSelf();

        Menu menu = MainActivity.getThis().getMenu();
        MenuItem appBarSwitch = menu.findItem(R.id.app_bar_switch);
        appBarSwitch.setActionView(R.layout.switch_item);
        appBarSwitch.setChecked(false);
        Switch mSwitch = menu.findItem(R.id.app_bar_switch).getActionView().findViewById(R.id.action_switch);
        mSwitch.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
            @Override
            public void onCheckedChanged(CompoundButton compoundButton, boolean isChecked) {
                if (isChecked) {
                    Intent intent = new Intent(getApplicationContext(), BroadcastReceiverService.class);
                    startService(intent);
                } else {
                    Intent intent = new Intent(getApplicationContext(), BroadcastReceiverService.class);
                    stopService(intent);
                }
            }
        });


    } else {
        Toast.makeText(this, "Service Started", Toast.LENGTH_SHORT).show();
    }
    return START_NOT_STICKY;

}